Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pylance typechecking enabled #327

Merged
merged 21 commits into from
Aug 26, 2022
Merged

Pylance typechecking enabled #327

merged 21 commits into from
Aug 26, 2022

Conversation

tinmarr
Copy link
Member

@tinmarr tinmarr commented Aug 26, 2022

Enable type checking from pylance. Very cool.

Hello reviewers!

Before approving this PR, please ensure the following:

  • Documentation is up to date
  • Relevent tutorials are up to date
  • Changelog is up to date
  • Test coverage is at 100%
  • All checks are passing
  • That the new code actually works

Once all this is done, you can be sure that the PR is ready to be merged. 🎉

This message has been added automatically. Please don't delete it.

@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 03:50 Inactive
@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 03:56 Inactive
@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 04:19 Inactive
@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 04:24 Inactive
This was referenced Aug 26, 2022
@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 06:53 Inactive
@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 07:06 Inactive
@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 07:09 Inactive
@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 16:14 Inactive
@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 17:08 Inactive
@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 18:42 Inactive
@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 18:59 Inactive
@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 19:07 Inactive
@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 19:14 Inactive
@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 19:50 Inactive
@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 20:01 Inactive
Copy link
Member

@tsedan tsedan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks goog

@github-actions github-actions bot temporarily deployed to Preview- August 26, 2022 20:23 Inactive
@tinmarr tinmarr enabled auto-merge (squash) August 26, 2022 20:25
@tinmarr tinmarr merged commit 2948f90 into main Aug 26, 2022
@tinmarr tinmarr deleted the pylance-typechecking-enabled branch August 26, 2022 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants