-
Notifications
You must be signed in to change notification settings - Fork 296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.5.1.0 #5561
Merged
Merged
v2.5.1.0 #5561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Back Add string extension to convert from VBA string literals to strings
Also correctly converts folder annotation arguments to the string content and back. This also removes the parentheses around folders.
It did not consider that there could be a getter in another module with the same name.
It moves the containing folder into another folder. Also fixes ToVbaStringLiteral. (It was missing the surrounding quotes.)
Also adds members to get the initial model to InteractiveRefactoringTestsBase.
There are already tests for the involved refactoring actions.
This moves interactive refactorings from using inheritance to deal with the interaction to composition. Consequently, the interaction can be reused elsewhere.
This combines MoveToFolder and MoveFolder, selecting based on the selected node of the CE. In principle, the backing refactoring actions are capable of dealing with multiple nodes at once. However, the CE only allows selecting single items at the moment and the command reflects that when deriving the models to pass to the refactoring actions.
The exception is moving into the project folder. This simply adds the explicit folder annotation.
The old form caused the parser to fail for a single missing argument at the start.
Fix argumentList
Consolidate Signature and Member content generation code
# Conflicts: # Rubberduck.Resources/RubberduckUI.resx
Also introduces Rubberduck.Resources.Refactoring.Refactoring.resx along with resx files for currently supported languages.
Creating a branch+PR rather than a direct commit, because preview isn't rendering the Paypal button
replaced form with static link
moved to a table further down a bit
added missing space
fixed newline
Adding donate button
A test was there, but the assert was wrong.
This is done in Rename-, MoveMultipleToFolder- and Move MultipleFoldersView. Also addresses one more review comment to PR #5438.
Introducing Move to Folder refactoring
Retains use of IModuleRewriterExtensions class.
Clean-up blank lines left behind by EncapsulateFieldRefactoring and MoveCloserToUsage
CodeBuilder - Provide 'casing friendly' default property RHS parameter name
Hello from "edit this page" link on the website 😄
…example-patch Update MissingModuleAnnotationInspection.cs
Removed resources used in code that will not be translated. They are now defined in the referencing objects.
This reverts commit f5205b8.
Defined within EF refactoring since it should not be translated.
Change CodeBuilder default property rhs parameter identifier to 'RHS'
Czech translations for v2.5.1
Changes build version to 2.5.1.x
WP article is ready, and @Vogel612 has already put together what could very well serve as release notes; when this sync finishes building I think we're good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Announcement article is not ready yet, and release notes still need to be drafted.
Do not merge before #5559.