Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.5.1.0 #5561

Merged
merged 612 commits into from
Aug 22, 2020
Merged

v2.5.1.0 #5561

merged 612 commits into from
Aug 22, 2020

Conversation

retailcoder
Copy link
Member

Announcement article is not ready yet, and release notes still need to be drafted.

Do not merge before #5559.

BZngr and others added 30 commits March 8, 2020 14:55
…Back

Add string extension to convert from VBA string literals to strings
Also correctly converts folder annotation arguments to the string content and back. This also removes the parentheses around folders.
It did not consider that there could be a getter in another module with the same name.
It moves the containing folder into another folder.

Also fixes ToVbaStringLiteral. (It was missing the surrounding quotes.)
Also adds members to get the initial model to InteractiveRefactoringTestsBase.
There are already tests for the involved refactoring actions.
This moves interactive refactorings from using inheritance to deal with the interaction to composition. Consequently, the interaction can be reused elsewhere.
This combines MoveToFolder and MoveFolder, selecting based on the selected node of the CE.
In principle, the backing refactoring actions are capable of dealing with multiple nodes at once. However, the CE only allows selecting single items at the moment and the command reflects that when deriving the models to pass to the refactoring actions.
The exception is moving into the project folder. This simply adds the explicit folder annotation.
The old form caused the parser to fail for a single missing argument at the start.
Consolidate Signature and Member content generation code
# Conflicts:
#	Rubberduck.Resources/RubberduckUI.resx
Also introduces Rubberduck.Resources.Refactoring.Refactoring.resx along
with resx files for currently supported languages.
Creating a branch+PR rather than a direct commit, because preview isn't rendering the Paypal button
replaced form with static link
moved to a table further down a bit
added missing space
fixed newline
A test was there, but the assert was wrong.
This is done in Rename-, MoveMultipleToFolder- and Move MultipleFoldersView.
Also addresses one more review comment to PR #5438.
Introducing Move to Folder refactoring
BZngr and others added 27 commits August 14, 2020 11:09
Retains use of IModuleRewriterExtensions class.
Clean-up blank lines left behind by EncapsulateFieldRefactoring and MoveCloserToUsage
CodeBuilder - Provide 'casing friendly' default property RHS parameter name
Hello from "edit this page" link on the website 😄
…example-patch

Update MissingModuleAnnotationInspection.cs
Removed resources used in code that will not be translated.  They are
now defined in the referencing objects.
This reverts commit f5205b8.
Defined within EF refactoring since it should not be translated.
Change CodeBuilder default property rhs parameter identifier to 'RHS'
Changes build version to 2.5.1.x
@retailcoder
Copy link
Member Author

WP article is ready, and @Vogel612 has already put together what could very well serve as release notes; when this sync finishes building I think we're good to go.

@retailcoder retailcoder marked this pull request as ready for review August 22, 2020 22:20
@retailcoder retailcoder merged commit 333bfa0 into master Aug 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants