…Back

Add string extension to convert from VBA string literals to strings

Also correctly converts folder annotation arguments to the string content and back. This also removes the parentheses around folders.

It did not consider that there could be a getter in another module with the same name.

It moves the containing folder into another folder.

Also fixes ToVbaStringLiteral. (It was missing the surrounding quotes.)

Also adds members to get the initial model to InteractiveRefactoringTestsBase.

There are already tests for the involved refactoring actions.

This moves interactive refactorings from using inheritance to deal with the interaction to composition. Consequently, the interaction can be reused elsewhere.

This combines MoveToFolder and MoveFolder, selecting based on the selected node of the CE.
In principle, the backing refactoring actions are capable of dealing with multiple nodes at once. However, the CE only allows selecting single items at the moment and the command reflects that when deriving the models to pass to the refactoring actions.

The exception is moving into the project folder. This simply adds the explicit folder annotation.

The old form caused the parser to fail for a single missing argument at the start.

Fix argumentList

Consolidate Signature and Member content generation code

# Conflicts:
#	Rubberduck.Resources/RubberduckUI.resx

Also introduces Rubberduck.Resources.Refactoring.Refactoring.resx along
with resx files for currently supported languages.

Creating a branch+PR rather than a direct commit, because preview isn't rendering the Paypal button

replaced form with static link

moved to a table further down a bit

added missing space

fixed newline

Adding donate button

A test was there, but the assert was wrong.

This is done in Rename-, MoveMultipleToFolder- and Move MultipleFoldersView.
Also addresses one more review comment to PR #5438.

Introducing Move to Folder refactoring

Introduces ICodeBuilder and CodeBuilder in place of extension methods.

There has to be at least one per required argument. All optional arguments have the last allowed type in the list.

Relocate ImplementInterface resource

This can happen accidentally. So this is a safeguard. Moving into itself explicitly---via the dialog version---is still possible.

Prohibit dragging and dropping a folder into itself

In octal numbering system only the digits 0-7 are valid.

Fix invalid octal digits range

…o next

… next

This reverts one of the two changes in the PR introducing the problems observed in issue #5442.

EncapsulateField minor UI tweaks

…next

The root problem is that the affected command did not consider that there might be no selection.

This caused an NRE.

In addition, a warning (doc-)comment is added to indicate that this base class is not suitable for members that can be accessed unqualified; there simply is no branch handling this case and it would either not work or even find the wrong usage context.

This restriction rules out all user code and all members on global instances as well as on document and form classes.

Added  MCVE tests.  Corrected XMLDoc example.

Also adds INotifyErrorInfo to ViewModelBase in order to allow more idiomatic validation in the UI.

…gation

Stop suppressing RequestBringIntoView in InspectionResultsControl

Fixes two null reference exceptions

Identified example module as 'Macros' and added comment to reinforce why
Public procedures of Standard Modules are ignored by the inspection.

Also fixes a bug in the setup of CodePane.GetQualifiedSelection in the MockProjectBuilder.

…o next

…next

Also reorganizes it a bit internally because the original setup did not work as expected.

In addition, default values are now set when switching the argument type.

# Conflicts:
#	Rubberduck.Resources/RubberduckUI.resx

Modifies IsResultReference(...) to avoid flagging an unused assignment that
preceeds a GoTo/Resume statement that branches execution to a
line in the procedure where the assignment could be used.

Forgotten '

The visibility of the individual annotations is based on the annotations applicable to the selected node.

…nterface_creates_private_classes

Modifies IsResultReference(...) to avoid flagging an unused assignment that
preceeds a GoTo/Resume statement that branches execution to a
line in the procedure where the assignment could be used.

…456_AssignNotUsed_Jumps

# Conflicts:

#	Rubberduck.CodeAnalysis/Inspections/Concrete/AssignmentNotUsedInspection.cs
#	RubberduckTests/Inspections/AssignmentNotUsedInspectionTests.cs

Missing VBA Comment apostrophe

Their declaration in XAML in made redundant by the ResourecDictionary.

If there is no attributes context, the annotation does not make sanse.
This is primarily a concern regarding variables, since module variables can have attributes, but local variables cannot. Accordingly, the annotation target enum is not sufficiently granular to provide all information.

The way it is set up, the ordering will not react to a change in UI culture, but that is OK since the dialog is modal; no possibility to get to the settings dialog during its lifetime.

It has sneaked in again in the last merge conflict resolution.

Since the AnnotateDeclataion UI shows a dropdown of all inspections for the argument of the Ignore and IgnoreModule annotations, having non-descriptive names looks really strange. We also cannot skip them because that means that they cannot be ignored this way.

Evaluate content where ":"  is used to places labels, statements, and
jump statements on the same line.

…next

It now looks like the indent sub menu.
This also fixes that the Refactorings sub menu was in the wrong place for ages.

This seems to cause a freeze while there is a scroll viewer on the grouping grid.

…TestExplorer

Removes handler for RequestBringIntoView from TestExplorer

Removes BlockNode demarcation from analysis allowing localVariables to
represent ProcedureScope regardless of where they are declared.
Remove false-positive result where an assignment is made using a
preceding assignment.

Added tests for #4913.
Modified tests to verify flagged results contain expected references and
do not contain unexpected references.  Checking result 'counts' can
allow failing tests to pass.