add reverse method of extract(string) #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
during PO.parse, an extract(string) method is called on each string to unescape some characters (like " and \). This process should be reverted in the toString method. The PO spec says, that all strings should be C-Strings. Otherwise tools like msgmerge (from the gettext package) will fail parsing po files written by this library.
|
If you need real world examples of translated strings that would create broken po-files, I could add some to the tests. For now, I just added some example strings, that don’t make any sense at all. |
|
You're right, we need to correct in both ways. The attached code looks good. Do add some broken real-life cases though, those are the best regression tests we can find. Preferably a test in both directions (parse and write). |
make sure, if a file containing c-string messages is identical after being parsed and written afterwards.
|
I added a new po file that can be used to test some real world messages containing escaped strings. For now, I just added an example that was broken in a project, I am working on. |
|
Cool, thanks, merging and pushing a release. |
rubenv
added a commit
that referenced
this pull request
Mar 5, 2014
add reverse method of extract(string)
|
Released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during PO.parse, an extract(string) method is called on each string to
unescape some characters (like " and ). This process should be reverted
in the toString method.
The PO spec says, that all strings should be C-Strings. Otherwise tools
like msgmerge (from the gettext package) will fail parsing po files written
by this library.
There is issue #2, that would bring a new extract method to PO.parse. When merging this, the escape-method should also be adopted to reflect this.