3567-0 #54

AnastasiyaKireyeva · 2019-07-08T11:35:19Z

Номер

3567

Номер задания

0

Ссылка на видео с демо

https://www.youtube.com/watch?v=4R5jCBqWP9E

And rebase from latest master for resolving this error:
Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

hound

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

hound · 2019-07-09T14:38:19Z

3567/0/about_symbols.rb

+  # against the string value rather than against symbols?
+
+  in_ruby_version('mri') do
+    RUBY_CONSTANT = 'What is the sound of one hand clapping?'.freeze


Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.

hound · 2019-07-09T14:38:19Z

3567/0/about_sandwich_code.rb

+    # rubocop:enable Security/Open
+    yield(file)
+  ensure
+    file.close if file


Style/SafeNavigation: Use safe navigation (&.) instead of checking if an object exists before calling the method.

hound · 2019-07-09T14:38:20Z

3567/0/about_sandwich_code.rb

+      # rubocop:enable Performance/RedundantMatch
+    end
+  ensure
+    file.close if file


Style/SafeNavigation: Use safe navigation (&.) instead of checking if an object exists before calling the method.

hound · 2019-07-09T14:38:20Z

3567/0/about_sandwich_code.rb

+    count += 1 while file.gets
+    count
+  ensure
+    file.close if file


Style/SafeNavigation: Use safe navigation (&.) instead of checking if an object exists before calling the method.

hound · 2019-07-09T14:38:20Z

3567/0/about_true_and_false.rb

+    assert_equal :false_stuff, truth_value(nil)
+  end
+
+  def test_everything_else_is_treated_as_true


TooManyStatements: AboutTrueAndFalse#test_everything_else_is_treated_as_true has approx 6 statements. More info.

hound · 2019-07-09T14:38:21Z

3567/0/about_strings.rb

+
+  def test_strings_are_unique_objects
+    a = 'a string'
+    b = 'a string'


UncommunicativeVariableName: AboutStrings#test_strings_are_unique_objects has the variable name 'b'. More info.

hound · 2019-07-09T14:38:22Z

3567/0/about_strings.rb

+  end
+
+  def test_strings_are_unique_objects
+    a = 'a string'


UncommunicativeVariableName: AboutStrings#test_strings_are_unique_objects has the variable name 'a'. More info.

hound · 2019-07-09T14:38:22Z

3567/0/about_strings.rb

+  def test_use_flexible_quoting_to_handle_really_hard_cases
+    a = %(flexible quotes can handle both ' and " characters)
+    b = %(flexible quotes can handle both ' and " characters)
+    c = %(flexible quotes can handle both ' and " characters)


UncommunicativeVariableName: AboutStrings#test_use_flexible_quoting_to_handle_really_hard_cases has the variable name 'c'. More info.

hound · 2019-07-09T14:38:22Z

3567/0/about_strings.rb

+
+  def test_use_flexible_quoting_to_handle_really_hard_cases
+    a = %(flexible quotes can handle both ' and " characters)
+    b = %(flexible quotes can handle both ' and " characters)


UncommunicativeVariableName: AboutStrings#test_use_flexible_quoting_to_handle_really_hard_cases has the variable name 'b'. More info.

hound · 2019-07-09T14:38:22Z

3567/0/about_strings.rb

+  end
+
+  def test_use_flexible_quoting_to_handle_really_hard_cases
+    a = %(flexible quotes can handle both ' and " characters)


UncommunicativeVariableName: AboutStrings#test_use_flexible_quoting_to_handle_really_hard_cases has the variable name 'a'. More info.

hound

Some files could not be reviewed due to errors:

Error: We found some problems with your configuration file: [/IrresponsibleMo...

Error: We found some problems with your configuration file: [/IrresponsibleModule] key 'IrresponsibleModule:' is undefined., [/DuplicateMethodCall] key 'DuplicateMethodCall:' is undefined., [/UtilityFunction] key 'UtilityFunction:' is undefined.

hound · 2019-07-09T17:02:35Z

3567/0/about_symbols.rb

+
+  def test_symbols_do_not_have_string_methods
+    symbol = :not_a_string
+    assert_equal false, symbol.respond_to?(:each_char)


ManualDispatch: AboutSymbols#test_symbols_do_not_have_string_methods manually dispatches method call. More info.

hound · 2019-07-09T17:02:35Z

3567/0/about_symbols.rb

+
+  def test_identical_symbols_are_a_single_internal_object
+    symbol1 = :a_symbol
+    symbol2 = :a_symbol


UncommunicativeVariableName: AboutSymbols#test_identical_symbols_are_a_single_internal_object has the variable name 'symbol2'. More info.

hound · 2019-07-09T17:02:35Z

3567/0/about_symbols.rb

+  end
+
+  def test_identical_symbols_are_a_single_internal_object
+    symbol1 = :a_symbol


UncommunicativeVariableName: AboutSymbols#test_identical_symbols_are_a_single_internal_object has the variable name 'symbol1'. More info.

hound · 2019-07-09T17:02:35Z

3567/0/about_symbols.rb

+  def test_symbols_can_be_compared
+    symbol1 = :a_symbol
+    symbol2 = :a_symbol
+    symbol3 = :something_else


UncommunicativeVariableName: AboutSymbols#test_symbols_can_be_compared has the variable name 'symbol3'. More info.

hound · 2019-07-09T17:02:35Z

3567/0/about_symbols.rb

+
+  def test_symbols_can_be_compared
+    symbol1 = :a_symbol
+    symbol2 = :a_symbol


UncommunicativeVariableName: AboutSymbols#test_symbols_can_be_compared has the variable name 'symbol2'. More info.

hound · 2019-07-09T17:02:36Z

3567/0/about_scoring_project.rb

+    assert_equal 0, score([2, 3, 4, 6])
+  end
+
+  def test_score_of_a_triple_1_is_1000


UncommunicativeMethodName: AboutScoringProject#test_score_of_a_triple_1_is_1000 has the name 'test_score_of_a_triple_1_is_1000'. More info.

hound · 2019-07-09T17:02:36Z

3567/0/about_scoring_project.rb

+    assert_equal 50, score([5])
+  end
+
+  def test_score_of_a_single_roll_of_1_is_100


UncommunicativeMethodName: AboutScoringProject#test_score_of_a_single_roll_of_1_is_100 has the name 'test_score_of_a_single_roll_of_1_is_100'. More info.

hound · 2019-07-09T17:02:37Z

3567/0/about_scoring_project.rb

+    assert_equal 0, score([])
+  end
+
+  def test_score_of_a_single_roll_of_5_is_50


UncommunicativeMethodName: AboutScoringProject#test_score_of_a_single_roll_of_5_is_50 has the name 'test_score_of_a_single_roll_of_5_is_50'. More info.

hound · 2019-07-09T17:02:37Z

3567/0/about_scoring_project.rb

+  array = []
+  result = 0
+  (1..6).each do |iteration|
+    array.append(dice.select { |item| item == iteration }.count)


NestedIterators: score contains iterators nested 2 deep. More info.

hound · 2019-07-09T17:02:37Z

3567/0/about_scoring_project.rb

+  result
+end
+
+def score(dice)


TooManyStatements: score has approx 9 statements. More info.

hound · 2019-07-09T18:02:26Z

3567/0/about_constants.rb

+C = 'top level'.freeze
+#:nodoc:
+class AboutConstants < Neo::Koan
+  C = 'nested'.freeze


Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.

hound · 2019-07-09T18:02:26Z

3567/0/about_constants.rb

+
+require File.expand_path(File.dirname(__FILE__) + '/neo')
+
+C = 'top level'.freeze


Style/RedundantFreeze: Do not freeze immutable objects, as freezing them has no effect.

hound · 2019-07-09T18:02:27Z

3567/0/example.rb

+    puts("введите слово:")
+    guess=gets.chomp()
+end
+puts "Вы выиграли"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
Layout/TrailingBlankLines: Final newline missing.

hound · 2019-07-09T18:02:27Z

3567/0/example.rb

+guess = ""
+while guess!=secret
+    puts("введите слово:")
+    guess=gets.chomp()


Layout/SpaceAroundOperators: Surrounding space missing for operator =.
Style/MethodCallWithoutArgsParentheses: Do not use parentheses for method calls with no arguments.

hound · 2019-07-09T18:02:27Z

3567/0/example.rb

+secret = "Loh"
+guess = ""
+while guess!=secret
+    puts("введите слово:")


Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-09T18:02:27Z

3567/0/example.rb

@@ -0,0 +1,7 @@
+secret = "Loh"
+guess = ""


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-09T18:02:27Z

3567/0/example.rb

@@ -0,0 +1,7 @@
+secret = "Loh"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-09T18:02:28Z

3567/0/about_control_statements.rb

+# frozen_string_literal: true
+#:reek:all:
+
+require File.expand_path(File.dirname(__FILE__) + '/neo') 


Layout/TrailingWhitespace: Trailing whitespace detected.

hound · 2019-07-09T18:02:28Z

3567/0/about_control_statements.rb

@@ -0,0 +1,164 @@
+# frozen_string_literal: true
+#:reek:all:


Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments.

3567/0/versioning_spec.rb

hound · 2019-07-10T12:13:57Z

3567/0/about_symbols.rb

+    symbol = :ruby
+    assert_equal true, symbol.is_a?(Symbol)
+  end
+


Layout/TrailingWhitespace: Trailing whitespace detected.

hound · 2019-07-10T12:16:26Z

3567/0/about_symbols.rb

+    assert_equal false, symbol1 == symbol3
+  end
+  # :reek:UncommunicativeVariableName:
+  def test_identical_symbols_are_a_single_internal_object


Layout/EmptyLineBetweenDefs: Use empty lines between method definitions.

hound · 2019-07-10T12:16:26Z

3567/0/about_symbols.rb

+    assert_equal true, symbol.is_a?(Symbol)
+  end
+  # :reek:UncommunicativeVariableName:
+  def test_symbols_can_be_compared


Layout/EmptyLineBetweenDefs: Use empty lines between method definitions.

DmitryAvramec · 2019-07-10T13:06:34Z

3567/0/triangle.rb

+#:reek:ControlParameter:reek:UtilityFunction:
+# :reek:ControlParameter:
+# :reek:FeatureEnvy:
+# rubocop:disable Style/SymbolProc, Metrics/AbcSize:


Remove disable

DmitryAvramec · 2019-07-10T13:06:45Z

3567/0/triangle.rb

+  (args[0] + args[1] <= args[2]) || (args[1] + args[2] <= args[0]) ||
+    (args[2] + args[0] <= args[1]) || args.any? { |argument| argument.negative? }
+end
+#:reek:ControlParameter:


All disables

DmitryAvramec · 2019-07-10T13:07:59Z

3567/0/about_scoring_project.rb

+# Your goal is to write the score method.
+
+def check_set_of_three_fives(array)
+  if array[4] >= 3


Digits are bad! Why its array[4]?

DmitryAvramec · 2019-07-10T13:10:09Z

3567/0/about_scoring_project.rb

+  array = []
+  result = 0
+  (1..6).each do |iteration|
+    array.append(dice.select { |item| item == iteration }.count)


O_o omg 🤦‍♂ dice.count(number) ?
Remove result = 0
Use reduce, inject, each_with_object instead of each

DmitryAvramec · 2019-07-10T13:11:39Z

3567/0/about_dice_project.rb

+
+# Implement a DiceSet Class here:
+#
+# class DiceSet


hound · 2019-07-12T13:18:13Z

3567/0/about_strings.rb

+
+  def test_strings_are_unique_objects
+    a = "a string"
+    b = "a string"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T13:18:13Z

3567/0/about_strings.rb

+  end
+
+  def test_strings_are_unique_objects
+    a = "a string"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T13:18:13Z

3567/0/about_strings.rb

+
+  def test_strings_can_be_joined
+    words = ["Now", "is", "the", "time"]
+    assert_equal "Now is the time", words.join(" ")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T13:18:13Z

3567/0/about_strings.rb

+  end
+
+  def test_strings_can_be_joined
+    words = ["Now", "is", "the", "time"]


Style/WordArray: Use %w or %W for an array of words.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T13:18:13Z

3567/0/about_strings.rb

+  end
+
+  def test_strings_can_be_split_with_different_patterns
+    string = "the:rain:in:spain"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T13:18:14Z

3567/0/about_strings.rb

+
+  in_ruby_version('1.8') do
+    def test_in_older_ruby_single_characters_are_represented_by_integers
+      assert_equal '97', ?a


Style/CharacterLiteral: Do not use the character literal - use string literal instead.

hound · 2019-07-12T13:18:14Z

3567/0/about_strings.rb

+  end
+
+  def test_you_can_get_a_single_character_from_a_string
+    string = "Bacon, lettuce and tomato"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T13:18:14Z

3567/0/about_strings.rb

+  end
+
+  def test_you_can_get_a_substring_from_a_string
+    string = "Bacon, lettuce and tomato"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T13:18:14Z

3567/0/about_strings.rb

+  def test_the_shovel_operator_modifies_the_original_string
+    original_string = 'Hello, '
+    hi = original_string
+    there = "World"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T13:18:15Z

3567/0/about_strings.rb

+
+  def test_the_shovel_operator_will_also_append_content_to_a_string
+    hi = "Hello, "
+    there = "World"


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T21:47:05Z

3567/0/about_classes.rb

+    assert_equal '[1, 2, 3]', array.inspect
+
+    assert_equal 'STRING', "STRING".to_s
+    assert_equal '"STRING"', "STRING".inspect


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T21:47:05Z

3567/0/about_classes.rb

+    assert_equal '[1, 2, 3]', array.to_s
+    assert_equal '[1, 2, 3]', array.inspect
+
+    assert_equal 'STRING', "STRING".to_s


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T21:47:05Z

3567/0/about_classes.rb

+  end
+
+  def test_inspect_provides_a_more_complete_string_version
+    fido = Dog7.new("Fido")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T21:47:05Z

3567/0/about_classes.rb

+  end
+
+  def test_to_s_is_used_in_string_interpolation
+    fido = Dog7.new("Fido")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T21:47:05Z

3567/0/about_classes.rb

+  end
+
+  def test_to_s_provides_a_string_version_of_the_object
+    fido = Dog7.new("Fido")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T21:47:06Z

3567/0/about_classes.rb

+
+  def test_you_can_create_accessor_methods_to_return_instance_variables
+    fido = Dog3.new
+    fido.setname("Fido")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T21:47:06Z

3567/0/about_classes.rb

+    def setname(a_name)
+      @name = a_name
+   end
+    def name


Layout/EmptyLineBetweenDefs: Use empty lines between method definitions.
Style/TrivialAccessors: Use attr_reader to define trivial reader methods.

hound · 2019-07-12T21:47:06Z

3567/0/about_classes.rb

+  class Dog3
+    def setname(a_name)
+      @name = a_name
+   end


Layout/DefEndAlignment: end at 68, 3 is not aligned with def at 66, 4.

hound · 2019-07-12T21:47:07Z

3567/0/about_classes.rb

+    fido = Dog2.new
+    fido.setname("Fido")
+    # rubocop:disable Style/EvalWithLocation
+    assert_equal 'Fido', fido.instance_eval("@name") # string version


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-12T21:47:07Z

3567/0/about_classes.rb

+
+  def test_you_can_rip_the_value_out_using_instance_eval
+    fido = Dog2.new
+    fido.setname("Fido")


Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.

hound · 2019-07-13T16:12:28Z

3567/0/about_constants.rb

+# frozen_string_literal: true
+
+# rubocop:disable Lint/MissingCopEnableDirective, Style/ClassAndModuleChildren
+# rubocop:disable Style/StringLiterals, Style/MutableConstant


Lint/UnneededCopDisableDirective: Unnecessary disabling of Style/MutableConstant.

hound · 2019-07-13T16:12:28Z

3567/0/about_symbols.rb

@@ -0,0 +1,109 @@
+# frozen_string_literal: true
+
+# rubocop:disable Style/StringLiterals, Style/MutableConstant


Lint/UnneededCopDisableDirective: Unnecessary disabling of Style/MutableConstant.

DmitryAvramec · 2019-07-14T13:36:00Z

3567/0/.vscode/settings.json

@@ -0,0 +1,4 @@
+{
+    "javascript.preferences.quoteStyle": "single",


DmitryAvramec · 2019-07-14T13:38:24Z

3567/0/about_arrays.rb

+
+require File.expand_path(File.dirname(__FILE__) + '/neo')
+
+# :reek:all:


26 :reek:all: If you want to disable some reek offenses disable it one-by-one and enable after the method where it appear

DmitryAvramec · 2019-07-14T13:39:07Z

3567/0/nly

@@ -0,0 +1,4 @@
+Inspecting 0 files


DmitryAvramec · 2019-07-14T13:39:40Z

3567/0/example.rb

@@ -0,0 +1,7 @@
+secret = 'Loh'


DmitryAvramec · 2019-07-15T10:08:17Z

3567/0/triangle.rb

+#   about_triangle_project_2.rb
+#
+
+#:reek:ControlParameter:reek:UtilityFunction and :reek:FeatureEnvy and :reek:ControlParameter


Here we have only your code, so fix these offenses with styling your code not with disables

DmitryAvramec · 2019-07-15T10:08:51Z

3567/0/about_scoring_project.rb

+
+TRIPLE = [nil, 1000, 200, 300, 400, 500, 600].freeze
+SINGLE = [nil, 100, 0, 0, 0, 50, 0].freeze
+# :reek:UtilityFunction


same as for triangle.rb

DmitryAvramec · 2019-07-15T10:10:38Z

3567/0/about_dice_project.rb

+
+require File.expand_path(File.dirname(__FILE__) + '/neo')
+
+# :reek:Attribute


@values

# Это 1-е сообщение коммита: Add the very very first homework task # Это сообщение коммита номер rubizza-camp#2: new rubocop config # Это сообщение коммита номер rubizza-camp#3: Let's 2019 begin # Это сообщение коммита номер rubizza-camp#4: Resolve reek issue with wrong config format # Это сообщение коммита номер rubizza-camp#5: Uploading source code files # Это сообщение коммита номер rubizza-camp#6: Deleting unnecessary file # Это сообщение коммита номер rubizza-camp#7: Correcting ruby styles # Это сообщение коммита номер rubizza-camp#8: Initial commit # Это сообщение коммита номер rubizza-camp#9: Fix for rubocop # Это сообщение коммита номер rubizza-camp#10: Fix for hound # Это сообщение коммита номер rubizza-camp#11: Fixing for hound and refactoring DiceSet # Это сообщение коммита номер rubizza-camp#12: Add homework 3715 for task 0 # Это сообщение коммита номер rubizza-camp#13: Fix issues indicated by the hound in homework 0 To pass the Hound and match the human style code. # Это сообщение коммита номер rubizza-camp#14: Create file_to_delete.md # Это сообщение коммита номер rubizza-camp#15: 3600 - 0 All files are checked via rubocop and reek # Это сообщение коммита номер rubizza-camp#16: Delete file_to_delete.md # Это сообщение коммита номер rubizza-camp#17: Create neo.rb # Это сообщение коммита номер rubizza-camp#18: Delete neo.rb # Это сообщение коммита номер rubizza-camp#19: Moved files to another folder # Это сообщение коммита номер rubizza-camp#20: Completed all ruby koans # Это сообщение коммита номер rubizza-camp#21: Fix most cod style for rubocop # Это сообщение коммита номер rubizza-camp#22: Fix some rubocop complaints # Это сообщение коммита номер rubizza-camp#23: Fix all koans indicated by the hound # Это сообщение коммита номер rubizza-camp#24: Renamed the latest commit # Это сообщение коммита номер rubizza-camp#25: Correct the error in triangle.rb # Это сообщение коммита номер rubizza-camp#26: Correct the alignments # Это сообщение коммита номер rubizza-camp#27: Solve half of Koans # Это сообщение коммита номер rubizza-camp#28: Solved all Koans # Это сообщение коммита номер rubizza-camp#29: Fix part of codestyle issues # Это сообщение коммита номер rubizza-camp#30: Fix half of codestyle issues # Это сообщение коммита номер rubizza-camp#31: Fix all codestyle issues # Это сообщение коммита номер rubizza-camp#32: Fix codestyle with new config Update config files Update config files Update config files Update config files # Это сообщение коммита номер rubizza-camp#33: Applied requested changes # Это сообщение коммита номер rubizza-camp#34: Fix about_control_statments # Это сообщение коммита номер rubizza-camp#35: Removed unnecessary rubocop:disables # Это сообщение коммита номер rubizza-camp#36: resloved koans and fixed rubocop # Это сообщение коммита номер rubizza-camp#37: fixed # Это сообщение коммита номер rubizza-camp#38: fix # Это сообщение коммита номер rubizza-camp#39: fix # Это сообщение коммита номер rubizza-camp#40: Fixed half reek's errors # Это сообщение коммита номер rubizza-camp#41: finished fix reek errors # Это сообщение коммита номер rubizza-camp#42: finished fix rubocop warnings # Это сообщение коммита номер rubizza-camp#43: fixed 'positive' warninig # Это сообщение коммита номер rubizza-camp#44: removed parentheses around a method call # Это сообщение коммита номер rubizza-camp#45: Come back koens's code and disable rubocop checker # Это сообщение коммита номер rubizza-camp#46: fixed variable name in test_methods_can_take_an_explicit_block_argument # Это сообщение коммита номер rubizza-camp#47: Edit method's arguments # Это сообщение коммита номер rubizza-camp#48: edit answer in test_methods_can_see_if_they_have_been_called_with_a_block use array.uniq in triangle.rb # Это сообщение коммита номер rubizza-camp#49: fixed rubocop's error # Это сообщение коммита номер rubizza-camp#50: simplify code(use case then 3 methods) and fixed wrong call enumerable method in check_below_zero_triagle # Это сообщение коммита номер rubizza-camp#51: simplify calling errors check and removed triangle_analyzes # Это сообщение коммита номер rubizza-camp#52: merge conditions and rename triangle_valud? into triangle_validate? # Это сообщение коммита номер rubizza-camp#53: delete redundant result # Это сообщение коммита номер rubizza-camp#54: fixed rubocop warning # Это сообщение коммита номер rubizza-camp#55: use new instance of array # Это сообщение коммита номер rubizza-camp#56: fixed space's warning # Это сообщение коммита номер rubizza-camp#57: init # Это сообщение коммита номер rubizza-camp#58: fix Style/StringLiterals errors in scope and sandwich # Это сообщение коммита номер rubizza-camp#59: fix Style/StringLiterals errors in sandwich # Это сообщение коммита номер rubizza-camp#60: fix Style/StringLiterals and Style/SymbolArray errors in scope triangle path # Это сообщение коммита номер rubizza-camp#61: fix Style/StringLiterals errors in variable_scope # Это сообщение коммита номер rubizza-camp#62: fix Style/StringLiterals and Style/SafeNavigation errors in sandwich and to_str # Это сообщение коммита номер rubizza-camp#63: fix Style/SafeNavigation and Style/SymbolProc errors in proxy and symbols # Это сообщение коммита номер rubizza-camp#64: disable rubocop and rewrite code in ctrl_statements # Это сообщение коммита номер rubizza-camp#65: disable rubocop in neo # Это сообщение коммита номер rubizza-camp#66: fix Style/WordArray and Style/StringLiterals errors in neo versioning strings # Это сообщение коммита номер rubizza-camp#67: fix Style/StringLiterals errors in module objects sandwich # Это сообщение коммита номер rubizza-camp#68: fix Style/StringLiterals errors and add empty lines in strings symbols # Это сообщение коммита номер rubizza-camp#69: delete unnecessary empty lines and fix Style/StringLiterals symbols triangle var_scope # Это сообщение коммита номер rubizza-camp#70: rewrite all tests # Это сообщение коммита номер rubizza-camp#71: disable rubocop and delete empty lines # Это сообщение коммита номер rubizza-camp#72: change rubocop config for fix Layout/EndOfLine # Это сообщение коммита номер rubizza-camp#73: change rubocop config and disable # Это сообщение коммита номер rubizza-camp#74: try fix Layout/EndOfLine error and enable rubocop # Это сообщение коммита номер rubizza-camp#75: try fix Layout/EndOfLine error # Это сообщение коммита номер rubizza-camp#76: test Layout/EndOfFile # Это сообщение коммита номер rubizza-camp#77: disable rubocop and fix Layout/EndOfLine error # Это сообщение коммита номер rubizza-camp#78: disable and enable rubocop # Это сообщение коммита номер rubizza-camp#79: disable rubocop and delete empty lines # Это сообщение коммита номер rubizza-camp#80: disable rubocop anmd change config # Это сообщение коммита номер rubizza-camp#81: disable rubocop # Это сообщение коммита номер rubizza-camp#82: fix @values in dice_project # Это сообщение коммита номер rubizza-camp#83: try change commit # Это сообщение коммита номер rubizza-camp#84: fix error with changing # Это сообщение коммита номер rubizza-camp#85: disable rubocop in neo # Это сообщение коммита номер rubizza-camp#86: try fix errors with change commits # Это сообщение коммита номер rubizza-camp#87: delete superfluous string in strings # Это сообщение коммита номер rubizza-camp#88: For the second PR # Это сообщение коммита номер rubizza-camp#89: Add Reek-disable comments # Это сообщение коммита номер rubizza-camp#90: Fix locally Reek and Rubocop by adding comments # Это сообщение коммита номер rubizza-camp#91: Fix Regexp performance issue in extra_credit # Это сообщение коммита номер rubizza-camp#92: Add tests(neo.rb, rake, etc) # Это сообщение коммита номер rubizza-camp#93: Fix a problem with spelling and naming in commit messages # Это сообщение коммита номер rubizza-camp#94: Upload files from ruby_koans # Это сообщение коммита номер rubizza-camp#95: Solve about_exceptions # Это сообщение коммита номер rubizza-camp#96: Solve TriangleError # Это сообщение коммита номер rubizza-camp#97: Change negative? check to positive? in triangle # Это сообщение коммита номер rubizza-camp#98: Solve about iterations # Это сообщение коммита номер rubizza-camp#99: Solve about blocks # Это сообщение коммита номер rubizza-camp#100: Solve about sandwich code # Это сообщение коммита номер rubizza-camp#101: Solve scoring project # Это сообщение коммита номер rubizza-camp#102: Solve about classes # Это сообщение коммита номер rubizza-camp#103: Solve about open classes # Это сообщение коммита номер rubizza-camp#104: Solve dice project # Это сообщение коммита номер rubizza-camp#105: Solve about inheritance # Это сообщение коммита номер rubizza-camp#106: Solve about modules # Это сообщение коммита номер rubizza-camp#107: Solve about scope # Это сообщение коммита номер rubizza-camp#108: Solve about class methods # Это сообщение коммита номер rubizza-camp#109: Solve about message passing # Это сообщение коммита номер rubizza-camp#110: Solve about proxy object project # Это сообщение коммита номер rubizza-camp#111: Fix all koans # Это сообщение коммита номер rubizza-camp#112: Fix part rubocop complains # Это сообщение коммита номер rubizza-camp#113: resolve shown violation # Это сообщение коммита номер rubizza-camp#114: Fix second portion rubocop # Это сообщение коммита номер rubizza-camp#115: Fix all rubocop complains except triangle and scoring # Это сообщение коммита номер rubizza-camp#116: Fix sandwich code # Это сообщение коммита номер rubizza-camp#117: Rewrite scoring project # Это сообщение коммита номер rubizza-camp#118: Change triangle code # Это сообщение коммита номер rubizza-camp#119: Fix hound complains # Это сообщение коммита номер rubizza-camp#120: Fix configs # Это сообщение коммита номер rubizza-camp#121: Change configs back # Это сообщение коммита номер rubizza-camp#122: Change about_scoring for AbcSize # Это сообщение коммита номер rubizza-camp#123: Add and fix about_variable_scope # Это сообщение коммита номер rubizza-camp#124: Add newline in the end of path to enlightenment # Это сообщение коммита номер rubizza-camp#125: Change do-end # Это сообщение коммита номер rubizza-camp#126: Finish koans, fix hound # Это сообщение коммита номер rubizza-camp#127: Auto # Это сообщение коммита номер rubizza-camp#128: fix all koans # Это сообщение коммита номер rubizza-camp#129: 3604 - 0 (rubizza-camp#120) * Created folder with number * Done all files, used rubocop and reek * Update about_sandwich_code.rb, error editing * The second update about_sandwich_code, fixed error * Fixed error Naming/ConstantName * Fixed error Style/MutableConstant * Fixed errors TooManyStatements and FeatureEnvy * Fixed error Style/MutableConstant * Updated file with new version code, used OOP * Updated file * Rewrote code, the code became clear * Fixed syntax private methods and public * Created normal name of method # Это сообщение коммита номер rubizza-camp#130: Initial commit # Это сообщение коммита номер rubizza-camp#131: fix rubocop # Это сообщение коммита номер rubizza-camp#132: update triangle.rb & change some rubocop # Это сообщение коммита номер rubizza-camp#133: Move to folder above 3548/0 # Это сообщение коммита номер rubizza-camp#134: load tasks fix about_asserts fix about_nil fix about_objects fix about_arrays fix about_array_assignment fix about_hashes fix about_strings fix about_symbols fix about_regular_expressions fix about_methods fix about_keyword_arguments fix about_constants fix about_control_statements fix about_true_and_false fix triangle fix about_exceptions fix about_iteration fix about_blocks fix about_sandwich_code fix about_scoring_project fix about_classes fix about_open_classes fix about_dice_project fix about_inheritance fix about_modules.rb fix about_scope fix about_class_methods fix about_message_passing fix about_proxy_object_project fix about_to_str fix about_variable_scope fix code style according ruby code style trying pass hound fix rake result pass hound undo reek file make new reek.yml fix code style according reek fix Layout/IndentationConsistency problem in about_scoring_project rename param name in set_name method in about_classes; delete useless about_extra_credit; delete redundant comment in about_proxy_object_project; fix indentation in about_scoring_project; delete redundant line in method 'bark' in about_variable_scope refactor method 'score' in about_scoring_project another score refactoring refactor method 'score': change conditions # Это сообщение коммита номер rubizza-camp#135: Done all, except extra task # Это сообщение коммита номер rubizza-camp#136: changed .hound.yml # Это сообщение коммита номер rubizza-camp#137: fix spacing # Это сообщение коммита номер rubizza-camp#138: solve reek problem # Это сообщение коммита номер rubizza-camp#139: argue with robocop # Это сообщение коммита номер rubizza-camp#140: make files in style

- successfully completed ruby koans - finally solved all rubocop offenses - examined and repaired all reek warnings - corrected all violations found by hound - reseted neo.rb - complemented scoring_project.rb - rebased from upstream master bf9cfa5 - perfectly resolved all mentor’s comments and suggestions - solved of all rubocop -a offenses and modified reek warnings

hound bot reviewed Jul 8, 2019

View reviewed changes

DmitryAvramec requested changes Jul 8, 2019

View reviewed changes

DmitryAvramec reviewed Jul 8, 2019

View reviewed changes

3567/0/about_variable_scope.rb Show resolved Hide resolved

hound bot reviewed Jul 9, 2019

View reviewed changes

3567/0/neo.rb Outdated Show resolved Hide resolved

3567/0/about_asserts.rb Outdated Show resolved Hide resolved

3567/0/Rakefile Outdated Show resolved Hide resolved

AnastasiyaKireyeva changed the title ~~Resolve all ruby koans~~ 3567-0 Jul 9, 2019

hound bot reviewed Jul 9, 2019

View reviewed changes

DmitryAvramec requested changes Jul 9, 2019

View reviewed changes

DmitryAvramec self-assigned this Jul 9, 2019

hound bot reviewed Jul 9, 2019

View reviewed changes

AnastasiyaKireyeva force-pushed the 3567-0 branch from ea44bd5 to 1ffdc4c Compare July 9, 2019 14:41

hound bot reviewed Jul 9, 2019

View reviewed changes

AnastasiyaKireyeva force-pushed the 3567-0 branch from 1ffdc4c to 125e761 Compare July 9, 2019 14:50

hound bot reviewed Jul 9, 2019

View reviewed changes

AnastasiyaKireyeva force-pushed the 3567-0 branch from 7bef38c to a547bb2 Compare July 9, 2019 18:02

hound bot reviewed Jul 9, 2019

View reviewed changes

AnastasiyaKireyeva force-pushed the 3567-0 branch 9 times, most recently from 1b0ab4f to 2612160 Compare July 10, 2019 11:39

hound bot reviewed Jul 10, 2019

View reviewed changes

AnastasiyaKireyeva force-pushed the 3567-0 branch from 56603b9 to 07b5b37 Compare July 10, 2019 12:40

DmitryAvramec requested changes Jul 10, 2019

View reviewed changes

AnastasiyaKireyeva force-pushed the 3567-0 branch from 9c4d91e to a33386c Compare July 10, 2019 13:11

DmitryAvramec requested changes Jul 10, 2019

View reviewed changes

3567/0/about_dice_project.rb Outdated

# Implement a DiceSet Class here:

#

# class DiceSet

Copy link

Contributor

DmitryAvramec Jul 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

AnastasiyaKireyeva force-pushed the 3567-0 branch 2 times, most recently from b34b7dc to 9e66094 Compare July 11, 2019 07:38

anatoliliotych added this to the HomeWork#0 milestone Jul 11, 2019

DmitryAvramec approved these changes Jul 11, 2019

View reviewed changes

hound bot reviewed Jul 12, 2019

View reviewed changes

AnastasiyaKireyeva force-pushed the 3567-0 branch from 04c11a4 to 539a7e2 Compare July 13, 2019 16:12

hound bot reviewed Jul 13, 2019

View reviewed changes

AnastasiyaKireyeva force-pushed the 3567-0 branch from 539a7e2 to 1d206ef Compare July 13, 2019 16:15

DmitryAvramec self-requested a review July 14, 2019 13:33

DmitryAvramec requested changes Jul 14, 2019

View reviewed changes

AnastasiyaKireyeva force-pushed the 3567-0 branch from 4d5ceae to e3129e3 Compare July 14, 2019 22:46

DmitryAvramec requested changes Jul 15, 2019

View reviewed changes

AnastasiyaKireyeva force-pushed the 3567-0 branch from e3129e3 to c79cca3 Compare July 15, 2019 11:58

DmitryAvramec approved these changes Jul 15, 2019

View reviewed changes

DmitryAvramec merged commit 2b062c9 into rubizza-camp:master Jul 15, 2019


		require File.expand_path(File.dirname(__FILE__) + '/neo')

		C = 'top level'.freeze

		@@ -0,0 +1,109 @@
		# frozen_string_literal: true

		# rubocop:disable Style/StringLiterals, Style/MutableConstant

		@@ -0,0 +1,4 @@
		{
		"javascript.preferences.quoteStyle": "single",


		require File.expand_path(File.dirname(__FILE__) + '/neo')

		# :reek:all:


		require File.expand_path(File.dirname(__FILE__) + '/neo')

		# :reek:Attribute

3567-0 #54

3567-0 #54

Conversation

AnastasiyaKireyeva commented Jul 8, 2019 • edited Loading

Номер

Номер задания

Ссылка на видео с демо

Комментарии

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

DmitryAvramec commented Jul 8, 2019

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

DmitryAvramec commented Jul 9, 2019

DmitryAvramec commented Jul 9, 2019

hound bot left a comment

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot left a comment

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

Choose a reason for hiding this comment

hound bot Jul 9, 2019

AnastasiyaKireyeva commented Jul 8, 2019 •

edited

Loading