Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minitest/RefuteRespondTo #29

Merged
merged 1 commit into from
Oct 16, 2019
Merged

Conversation

herwinw
Copy link
Contributor

@herwinw herwinw commented Oct 15, 2019

Similar to Minitest/AssertRespondTo, includes a lot of copy-paste. The style guide was present.


Before submitting the PR make sure the following are checked:

  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Added an entry to the Changelog if the new code introduces user-observable changes. See changelog entry format.
  • The PR relates to only one subject with a clear title
    and description in grammatically correct, complete sentences.
  • Run bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.

config/default.yml Outdated Show resolved Hide resolved
@abhaynikam
Copy link
Contributor

abhaynikam commented Oct 15, 2019

@herwinw : you need to add a changelog entry for this change and squash commits in one. Rest LGTM 🎉

@herwinw
Copy link
Contributor Author

herwinw commented Oct 15, 2019

Changelog has been added as well.

@herwinw herwinw mentioned this pull request Oct 15, 2019
8 tasks
@bbatsov bbatsov merged commit 13f5dc7 into rubocop:master Oct 16, 2019
@bbatsov
Copy link
Contributor

bbatsov commented Oct 16, 2019

Thanks!

@herwinw herwinw deleted the refute_respond_to branch October 16, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants