Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeletePrefix and DeleteSuffix should detect sub/sub! String methods #115

Closed
fatkodima opened this issue May 24, 2020 · 0 comments · Fixed by #116
Closed

DeletePrefix and DeleteSuffix should detect sub/sub! String methods #115

fatkodima opened this issue May 24, 2020 · 0 comments · Fixed by #116
Labels
enhancement

Comments

@fatkodima
Copy link
Contributor

DeletePrefix and DeleteSuffix cops currently only detect gsub/gsub! String methods.
Should also detect and correct sub/sub! methods (https://ruby-doc.org/core-2.5.0/String.html#method-i-sub).

Like:

"FooController".sub(/Controller$/) => "FooController".delete_suffix("Controller")
fatkodima added a commit to fatkodima/rubocop-performance that referenced this issue May 24, 2020
@fatkodima
[Fix rubocop#115] DeletePrefix and DeleteSuffix cops detects sub/sub!…
d1933cc 
… String methods
fatkodima added a commit to fatkodima/rubocop-performance that referenced this issue May 24, 2020
@fatkodima
[Fix rubocop#115] DeletePrefix and DeleteSuffix cops detects sub/sub!…
ea2e077 
… String methods
@fatkodima fatkodima mentioned this issue May 24, 2020
Merged
@koic koic closed this as completed in #116 May 26, 2020
koic added a commit that referenced this issue May 26, 2020
@koic
Merge pull request #116 from fatkodima/delete_suffix_prefix-sub-method
aef2416 
[Fix #115] DeletePrefix and DeleteSuffix cops detects sub/sub! String methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
2 participants
@koic @fatkodima