[Fix #9380] Mark Style/FloatDivision as unsafe

Fixes #9380. This PR marks `Style/FloatDivision` as unsafe. If operand variable is a string object then `.to_f` will be removed and an error will occur.
rubocop · Jan 15, 2021 · d939849 · d939849
1 parent b72ae11
commit d939849
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 0 deletions.
diff --git a/changelog/change_mark_unsafe_for_style_float_division.md b/changelog/change_mark_unsafe_for_style_float_division.md
@@ -0,0 +1 @@
+* [#9380](https://github.com/rubocop-hq/rubocop/issues/9380): Mark `Style/FloatDivision` as unsafe. ([@koic][])
diff --git a/config/default.yml b/config/default.yml
@@ -3307,6 +3307,7 @@ Style/FloatDivision:
   Enabled: true
   VersionAdded: '0.72'
   VersionChanged: '1.6'
+  Safe: false
   EnforcedStyle: single_coerce
   SupportedStyles:
     - left_coerce

diff --git a/lib/rubocop/cop/style/float_division.rb b/lib/rubocop/cop/style/float_division.rb
@@ -7,6 +7,9 @@ module Style
       # It is recommended to either always use `fdiv` or coerce one side only.
       # This cop also provides other options for code consistency.
       #
+      # This cop is marked as unsafe, because if operand variable is a string object
+      # then `.to_f` will be removed and an error will occur.
+      #
       # @example EnforcedStyle: single_coerce (default)
       #   # bad
       #   a.to_f / b.to_f