Style/ConstantVisibility needs ♥️

[marcandre]

The Style::ConstantVisibility cop has potential but could be made much more useful.

False positives: it should detect # @api private (or # @api public) in the associated comment, and also detect if the parent module is itself private (either via private_constant or @api private).

Modules vs literals: it should allow a config 'ExcludeModules' to restrict detection of literals only (EXAMPLE = 42, and not SomeClass = Struct.new()). Typically nested modules and classes are public, but literals should be private.

Auto-correction: it should offer auto-correction. A config option like DefaultVisibility could make it much nicer. Values could be: 'private_constant', 'public_constant', '@api private', or '@api public'. Autocorrector should be mindful of constants containing heredocs and/or assignments ending with comments.

[bbatsov]

Yeah, totally agreed. Lots of room for improvement there.