-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0 does not add Layout/SpaceInsideBlockBraces and Layout/SpaceInsideHashLiteralBraces excluding files to .rubocop_todo.yml #8938
Labels
Comments
marutosi
changed the title
1.0 does not add Layout/SpaceInsideBlockBraces and Layout/SpaceInsideBlockBraces excluding files to .rubocop_todo.yml
1.0 does not add Layout/SpaceInsideBlockBraces and Layout/SpaceInsideHashLiteralBraces excluding files to .rubocop_todo.yml
Oct 25, 2020
Hitting this same issue. This also applies to:
|
Experiencing this on 1.3 as well. Preventing us upgrading to use recent |
8 tasks
h-lame
added a commit
to h-lame/rubocop
that referenced
this issue
Dec 23, 2020
…alsInParameterDefault` The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Prior to this commit, this cop _only_ called `correct_style_detected` which means it would always output `EnforcedStyle: <some value>` during `--auto-gen-config` runs. If the code under review actually has a mix of styles rather than a single consistent style then the generated config for this cop in `.rubocop_todo.yml` will not produce a passing review as instead of an exclusion list, or turning the cop off, it will only have the `EnforcedStyle: <some value>` config. This commit calls `opposite_style_detected` when we call `add_offense` to avoid this problem. Note: to use `opposite_style_detected` we need exactly two supported styles to be configured, which they are in `default.yml`, but one of the specs for `LeadingEmptyLines` runs this cop with slimmed down config so we have to fix that config.
h-lame
added a commit
to h-lame/rubocop
that referenced
this issue
Dec 23, 2020
…ckBraces` The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Prior to this commit, this cop _only_ called `correct_style_detected` which means it would always output `EnforcedStyle: <some value>` during `--auto-gen-config` runs. If the code under review actually has a mix of styles rather than a single consistent style then the generated config for this cop in `.rubocop_todo.yml` will not produce a passing review as instead of an exclusion list, or turning the cop off, it will only have the `EnforcedStyle: <some value>` config. This commit calls `opposite_style_detected` when we call `add_offense` to avoid this problem.
h-lame
added a commit
to h-lame/rubocop
that referenced
this issue
Dec 23, 2020
The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Prior to this commit, this cop _only_ called `correct_style_detected` which means it would always output `EnforcedStyle: <some value>` during `--auto-gen-config` runs. If the code under review actually has a mix of styles rather than a single consistent style then the generated config for this cop in `.rubocop_todo.yml` will not produce a passing review as instead of an exclusion list, or turning the cop off, it will only have the `EnforcedStyle: <some value>` config. This commit calls `opposite_style_detected` when we call `add_offense` to avoid this problem.
h-lame
added a commit
to h-lame/rubocop
that referenced
this issue
Dec 23, 2020
The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Prior to this commit, this cop _only_ called `correct_style_detected` which means it would always output `EnforcedStyle: <some value>` during `--auto-gen-config` runs. If the code under review actually has a mix of styles rather than a single consistent style then the generated config for this cop in `.rubocop_todo.yml` will not produce a passing review as instead of an exclusion list, or turning the cop off, it will only have the `EnforcedStyle: <some value>` config. This commit calls `opposite_style_detected` when we call `add_offense` to avoid this problem.
h-lame
added a commit
to h-lame/rubocop
that referenced
this issue
Dec 23, 2020
…eclarations` The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Prior to this commit, this cop called `correct_style_detected` and `opposite_style_detected` correctly, but it did not call `add_offense` to register the offenses correctly. This has two outcomes: 1. During a normal run the cop would only report 1 offense for the whole code base under review. When this is fixed it would then report the next offense. 2. During a `--auto-gen-config` run the cop would only output the first file it encountered an offense in an `Exclude` list which means the configuration generated for this cop in `.rubocop_todo.yml` will not produce a passing review. This commit stops treating `opposite_style_detected` as a predicate to decide if we should call `add_offense` and instead always calls both methods.
h-lame
added a commit
to h-lame/rubocop
that referenced
this issue
Dec 23, 2020
…heses` The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Prior to this commit, this cop _only_ called `correct_style_detected` which means it would always output `EnforcedStyle: <some value>` during `--auto-gen-config` runs. If the code under review actually has a mix of styles rather than a single consistent style then the generated config for this cop in `.rubocop_todo.yml` will not produce a passing review as instead of an exclusion list, or turning the cop off, it will only have the `EnforcedStyle: <some value>` config. This commit calls `unexpected_style_detected`, passing in the relevant detected incorrect style whenever we call `add_offense` to avoid this problem. We can't use `opposite_style_detected` because this cop has more than 2 supported styles.
h-lame
added a commit
to h-lame/rubocop
that referenced
this issue
Dec 23, 2020
…LiteralBraces` The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Prior to this commit, this cop called `correct_style_detected` correctly on success, but made several mistakes with calling `ambiguous_style_detected` or `unexpected_style_detected` on error. It treated these methods as predicates and wouldn't call `add_offense` if they returned `true` so the detected offenses would not be registered. It also passed the wrong `style` parameter to these methods - it passed the configured style from `EnforcedStyle` rather than the one detected by the offense. This means: 1. During a normal run the cop would not report all offenses detected in the whole code base under review. 2. During a `--auto-gen-config` run the cop would only ever output `EnforcedStyle: <some value>`. If the code under review actually has a mix of styles rather than a single consistent style then the generated config for this cop in `.rubocop_todo.yml` will not produce a passing review as instead of an exclusion list, or turning the cop off, it will only have the `EnforcedStyle: <some value>` config. This commit corrects both the errors: it passes the detected incorrect style when calling `ambiguous_style_detected` or `unexpected_style_detected` and always calls `add_offense` instead of treating the return value of `ambiguous_style_detected` or `unexpected_style_detected` as a predicate to decide if it should or not.
h-lame
added a commit
to h-lame/rubocop
that referenced
this issue
Dec 23, 2020
…kBraces` The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Importantly, this API should _only_ be used when the offense is caused by the configuration handled by `EnforcedStyle`. Prior to this commit, this cop was inconsistent about when it called `correct_style_detected` on success and `opposite_style_detected` on failure. This means it would always output `EnforcedStyle: <some value>` during `--auto-gen-config` runs. If the code under review actually has a mix of styles rather than a single consistent style then the generated config for this cop in `.rubocop_todo.yml` will not produce a passing review as instead of an exclusion list, or turning the cop off, it will only have the `EnforcedStyle: <some value>` config. This commit makes sure we always call `opposite_style_detected` when we call `add_offense`, and always call `correct_style_detected` when we don't detect an offense. Note, because this cop has separate style choices for braces with contents, `EnforcedStyle`, and empty braces without contents, `EnforcedStyleForEmptyBraces`, we also have to make sure to only call the `xxx_style_detected` methods when the offenses / passes are detected for the former as the API provided by `ConfigurableEnforcedStyle` only applies to `EnforcedStyle` config.
bbatsov
pushed a commit
that referenced
this issue
Dec 24, 2020
…rameterDefault` The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Prior to this commit, this cop _only_ called `correct_style_detected` which means it would always output `EnforcedStyle: <some value>` during `--auto-gen-config` runs. If the code under review actually has a mix of styles rather than a single consistent style then the generated config for this cop in `.rubocop_todo.yml` will not produce a passing review as instead of an exclusion list, or turning the cop off, it will only have the `EnforcedStyle: <some value>` config. This commit calls `opposite_style_detected` when we call `add_offense` to avoid this problem. Note: to use `opposite_style_detected` we need exactly two supported styles to be configured, which they are in `default.yml`, but one of the specs for `LeadingEmptyLines` runs this cop with slimmed down config so we have to fix that config.
bbatsov
pushed a commit
that referenced
this issue
Dec 24, 2020
The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Prior to this commit, this cop _only_ called `correct_style_detected` which means it would always output `EnforcedStyle: <some value>` during `--auto-gen-config` runs. If the code under review actually has a mix of styles rather than a single consistent style then the generated config for this cop in `.rubocop_todo.yml` will not produce a passing review as instead of an exclusion list, or turning the cop off, it will only have the `EnforcedStyle: <some value>` config. This commit calls `opposite_style_detected` when we call `add_offense` to avoid this problem.
bbatsov
pushed a commit
that referenced
this issue
Dec 24, 2020
The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Prior to this commit, this cop _only_ called `correct_style_detected` which means it would always output `EnforcedStyle: <some value>` during `--auto-gen-config` runs. If the code under review actually has a mix of styles rather than a single consistent style then the generated config for this cop in `.rubocop_todo.yml` will not produce a passing review as instead of an exclusion list, or turning the cop off, it will only have the `EnforcedStyle: <some value>` config. This commit calls `opposite_style_detected` when we call `add_offense` to avoid this problem.
bbatsov
pushed a commit
that referenced
this issue
Dec 24, 2020
The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Prior to this commit, this cop _only_ called `correct_style_detected` which means it would always output `EnforcedStyle: <some value>` during `--auto-gen-config` runs. If the code under review actually has a mix of styles rather than a single consistent style then the generated config for this cop in `.rubocop_todo.yml` will not produce a passing review as instead of an exclusion list, or turning the cop off, it will only have the `EnforcedStyle: <some value>` config. This commit calls `opposite_style_detected` when we call `add_offense` to avoid this problem.
bbatsov
pushed a commit
that referenced
this issue
Dec 24, 2020
…ions` The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Prior to this commit, this cop called `correct_style_detected` and `opposite_style_detected` correctly, but it did not call `add_offense` to register the offenses correctly. This has two outcomes: 1. During a normal run the cop would only report 1 offense for the whole code base under review. When this is fixed it would then report the next offense. 2. During a `--auto-gen-config` run the cop would only output the first file it encountered an offense in an `Exclude` list which means the configuration generated for this cop in `.rubocop_todo.yml` will not produce a passing review. This commit stops treating `opposite_style_detected` as a predicate to decide if we should call `add_offense` and instead always calls both methods.
bbatsov
pushed a commit
that referenced
this issue
Dec 24, 2020
The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Prior to this commit, this cop _only_ called `correct_style_detected` which means it would always output `EnforcedStyle: <some value>` during `--auto-gen-config` runs. If the code under review actually has a mix of styles rather than a single consistent style then the generated config for this cop in `.rubocop_todo.yml` will not produce a passing review as instead of an exclusion list, or turning the cop off, it will only have the `EnforcedStyle: <some value>` config. This commit calls `unexpected_style_detected`, passing in the relevant detected incorrect style whenever we call `add_offense` to avoid this problem. We can't use `opposite_style_detected` because this cop has more than 2 supported styles.
bbatsov
pushed a commit
that referenced
this issue
Dec 24, 2020
…Braces` The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Prior to this commit, this cop called `correct_style_detected` correctly on success, but made several mistakes with calling `ambiguous_style_detected` or `unexpected_style_detected` on error. It treated these methods as predicates and wouldn't call `add_offense` if they returned `true` so the detected offenses would not be registered. It also passed the wrong `style` parameter to these methods - it passed the configured style from `EnforcedStyle` rather than the one detected by the offense. This means: 1. During a normal run the cop would not report all offenses detected in the whole code base under review. 2. During a `--auto-gen-config` run the cop would only ever output `EnforcedStyle: <some value>`. If the code under review actually has a mix of styles rather than a single consistent style then the generated config for this cop in `.rubocop_todo.yml` will not produce a passing review as instead of an exclusion list, or turning the cop off, it will only have the `EnforcedStyle: <some value>` config. This commit corrects both the errors: it passes the detected incorrect style when calling `ambiguous_style_detected` or `unexpected_style_detected` and always calls `add_offense` instead of treating the return value of `ambiguous_style_detected` or `unexpected_style_detected` as a predicate to decide if it should or not.
bbatsov
pushed a commit
that referenced
this issue
Dec 24, 2020
The expected use of the API provided by `ConfigurableEnforcedStyle` is for the cop to call `correct_style_detected` if the cop detects no offense or to call one of the other `xxx_style_detected` api methods if it does detect an offense, and it should also call `add_offense` to register the offense. Doing this updates `config_to_allow_offenses` which is used during `--auto-gen-config` to decide how to configure the cop for the current code under review so that regardless of the styles used the code passes review. Importantly, this API should _only_ be used when the offense is caused by the configuration handled by `EnforcedStyle`. Prior to this commit, this cop was inconsistent about when it called `correct_style_detected` on success and `opposite_style_detected` on failure. This means it would always output `EnforcedStyle: <some value>` during `--auto-gen-config` runs. If the code under review actually has a mix of styles rather than a single consistent style then the generated config for this cop in `.rubocop_todo.yml` will not produce a passing review as instead of an exclusion list, or turning the cop off, it will only have the `EnforcedStyle: <some value>` config. This commit makes sure we always call `opposite_style_detected` when we call `add_offense`, and always call `correct_style_detected` when we don't detect an offense. Note, because this cop has separate style choices for braces with contents, `EnforcedStyle`, and empty braces without contents, `EnforcedStyleForEmptyBraces`, we also have to make sure to only call the `xxx_style_detected` methods when the offenses / passes are detected for the former as the API provided by `ConfigurableEnforcedStyle` only applies to `EnforcedStyle` config.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
0.89
https://github.com/marutosi/redmine/blob/82b58d98dff30edd6884696b596b00aba2050369/Gemfile#L95
https://github.com/marutosi/redmine/blob/82b58d98dff30edd6884696b596b00aba2050369/.rubocop_todo.yml#L762
1.0
https://github.com/marutosi/redmine/blob/f730543ddee2d4bc4e547908f711df3320a31d18/Gemfile#L95
https://github.com/marutosi/redmine/blob/f730543ddee2d4bc4e547908f711df3320a31d18/.rubocop_todo.yml#L866
The text was updated successfully, but these errors were encountered: