Fix Layout/SpaceAroundBlockParameters bug related to trailing commas #8084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bquorning
force-pushed
the
space_around_block_parameters_spec-bug
branch
from
e3150d2
to
8100dec
Compare
bquorning
commented
Jun 2, 2020
| processed_source.buffer.source[pos] == ',' ? pos + 1 : pos | ||
| def last_end_pos_inside_pipes(arguments, pos) | ||
| num = pos - arguments.source_range.to_a.first | ||
| trailing_comma_index = arguments.source[num..-1].index(',') |
There was a problem hiding this comment.
There must be a smarter way to do this :-)
There was a problem hiding this comment.
I don't think so; parser doesn't give out any info about the commas
marcandre
reviewed
Jun 2, 2020
| processed_source.buffer.source[pos] == ',' ? pos + 1 : pos | ||
| def last_end_pos_inside_pipes(arguments, pos) | ||
| num = pos - arguments.source_range.to_a.first | ||
| trailing_comma_index = arguments.source[num..-1].index(',') |
There was a problem hiding this comment.
I don't think so; parser doesn't give out any info about the commas
bquorning
force-pushed
the
space_around_block_parameters_spec-bug
branch
from
c3de612
to
83e5cfd
Compare
bquorning
changed the title
bquorning
force-pushed
the
space_around_block_parameters_spec-bug
branch
2 times, most recently
from
2efef3b
to
7d26ac8
Compare
|
@bquorning Can you rebase this PR? |
bbatsov
approved these changes
Nov 4, 2020
There was a bug in how Layout/SpaceAroundBlockParameters autocorrected block parameters with a trailing comma with both leading and trailing whitespace.
bquorning
force-pushed
the
space_around_block_parameters_spec-bug
branch
from
7d26ac8
to
0f34b08
Compare
|
I had completely forgotten about this PR :-) It’s rebased now. |
|
Thanks!
I forget about most PRs, especially if they are not on the first scree. That's why I did a lot of PR pruning today. It's great when you have no more than 25 of them. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug in how Layout/SpaceAroundBlockParameters autocorrected block parameters with a trailing comma with both leading and trailing whitespace.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and RuboCop for itself, and generates the documentation.