Make Lint/NonDeterministicRequireOrder not to register offense for Ruby 3
#9300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
koic
added a commit
to koic/rubocop
that referenced
this pull request
Dec 29, 2020
Sort globbed results by default in Ruby 3.0. https://bugs.ruby-lang.org/issues/8709 This PR adds new `Lint/RedundantDirGlobSort` cop. It checks for redundant `sort` method to `Dir.glob` and `Dir[]`. ```ruby # bad Dir.glob('./lib/**/*.rb').sort.each do |file| end Dir['./lib/**/*.rb'].sort.each do |file| end # good Dir.glob('./lib/**/*.rb').each do |file| end Dir['./lib/**/*.rb'].each do |file| end # good - Respect intent if `sort` keyword option is specified. Dir.glob('./lib/**/*.rb', sort: false).each do |file| end ``` Related PR rubocop#9300.
…Ruby 3 `Dir.glob` and `Dir[]` sort the results by default in Ruby 3.0. - https://bugs.ruby-lang.org/issues/8709 - ruby/ruby@2f1081a This PR will make not to register an offense when using Ruby 3.0. So users don't need this cop when using Ruby 3.0. It can be deprecated when supporting only Ruby 3.0 and higher. I will open a PR about a new cop against `Dir.glob.sort` and `Dir[]`.sort, which became redundant in Ruby 3.0.
koic
force-pushed
the
change_make_deterministic_require_order_not_to_register_offense_for_ruby3
branch
from
e2110e1
to
7ac1922
Compare
bbatsov
pushed a commit
that referenced
this pull request
Dec 31, 2020
Sort globbed results by default in Ruby 3.0. https://bugs.ruby-lang.org/issues/8709 This PR adds new `Lint/RedundantDirGlobSort` cop. It checks for redundant `sort` method to `Dir.glob` and `Dir[]`. ```ruby # bad Dir.glob('./lib/**/*.rb').sort.each do |file| end Dir['./lib/**/*.rb'].sort.each do |file| end # good Dir.glob('./lib/**/*.rb').each do |file| end Dir['./lib/**/*.rb'].each do |file| end # good - Respect intent if `sort` keyword option is specified. Dir.glob('./lib/**/*.rb', sort: false).each do |file| end ``` Related PR #9300.
|
Thanks! |
koic
deleted the
change_make_deterministic_require_order_not_to_register_offense_for_ruby3
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dir.globandDir[]sort the results by default in Ruby 3.0.This PR will make not to register an offense when using Ruby 3.0.
So users don't need this cop when using Ruby 3.0.
It can be deprecated when supporting only Ruby 3.0 and higher.
I will open a PR about a new cop against
Dir.glob.sortandDir[].sort, which became redundant in Ruby 3.0.Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.