Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for v2 of
unicode-display_width
. This version emits a warning when requiring theno_string_ext
version, since omittingString
extensions is the default. To compensate, I've reverted to the normalrequire
, but this will of course includeString
extensions when the gem version is < 2. (It may make sense to require theunicode-display_width
version be >= 2, to avoid unintentionally using a conflictingString
API, let me know which approach you'd prefer.)The only use of this library appears to be an invocation of
Unicode::DisplayWidth.of
inlib/rubocop/cop/mixin/alignment.rb
, so this should be compatible with the v2 library changes.Before submitting the PR make sure the following are checked:
[Fix #issue-number]
(if the related issue exists).master
(if not - rebase it).bundle exec rake default
. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.md
if the new code introduces user-observable changes. See changelog entry format for details.