Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unicode-display_width v2 #9320

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Conversation

dduugg
Copy link
Contributor

@dduugg dduugg commented Dec 31, 2020

Adds support for v2 of unicode-display_width. This version emits a warning when requiring the no_string_ext version, since omitting String extensions is the default. To compensate, I've reverted to the normal require, but this will of course include String extensions when the gem version is < 2. (It may make sense to require the unicode-display_widthversion be >= 2, to avoid unintentionally using a conflicting String API, let me know which approach you'd prefer.)

The only use of this library appears to be an invocation of Unicode::DisplayWidth.of in lib/rubocop/cop/mixin/alignment.rb, so this should be compatible with the v2 library changes.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@bbatsov bbatsov merged commit c460feb into rubocop:master Jan 4, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 4, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants