Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Style/MutableConstant as unsafe #9331

Merged
merged 1 commit into from
Jan 4, 2021

Conversation

koic
Copy link
Member

@koic koic commented Jan 4, 2021

Follow #8529.

Style/MutableConstant is the same as Style/FrozenStringLiteralComment, freezing object is unsafe auto-correction.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

Follow rubocop#8529.

`Style/MutableConstant` is the same as `Style/FrozenStringLiteralComment`,
freezing object is unsafe auto-correction.
@bbatsov bbatsov merged commit b5da2b4 into rubocop:master Jan 4, 2021
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 4, 2021

Thanks!

@koic koic deleted the mark_style_mutable_constant_as_unsafe branch January 4, 2021 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants