Don't enforce cops after __END__

[lloeki]

__END__ can be used to mark the end of a Ruby file, and the remainder can be used as raw data. Homebrew uses this to include simple patches straight inside its formulas.

[bbatsov]

I'm not sure RuboCop should handle this or parser. @whitequark what do you think? Perhaps parser should simply ignore code after __END__.

[whitequark]

Parser ignores code after __END__.

$ ruby-parse -e $'foo\n__END__\nbar'
(send nil :foo)

[jonas054]

I think the only cops that have a problem with __END__ are the ones that examine code line-by-line:

• Metrics/LineLength
• Style/EndOfLine
• Style/CommentIndentation
• Style/Tab
• Style/TrailingWhitespace
• Style/TrailingBlankLines [Edit: Added this one after @lloeki's comment below]

Does that sound about right, @lloeki, or did you run into problems with other cops?

[bbatsov]

Yeah, you're probably right.

[lloeki]

Those are the ones I encountered:

Style/TrailingWhitespace:
    Enabled: false
Style/Tab:
    Enabled: false
Style/TrailingBlankLines:
    Enabled: false

[thomthom]

I'm running into Lint/Syntax errors in text after __END__ when the file is using Carriage Returns for new lines:

We are using RuboCop to review third party source code where we ran into this scenario.

I looks like Ruby's String#lines only splits at \n. So when we have these odd files with \r then RuboCop fails to stop at __END__.

Could an alternative be to use .split(/\n\r|\r\n|\n|\r/)?

Had this been our own code we could fix it by saving with different line endings. But since we use RuboCop to review third party source for extensions to our application we cannot easily do that. And since Ruby files with \r for line endings still evaluates it would be a challenge to argue that we enforce such a given line ending style.

[jonas054]

1. Syntax errors come from the parser gem, and RuboCop just picks them up and presents them.
2. Ruby on Ubuntu rejects the given example code. I've tried with ruby-2.3, 2.4 and 2.5.

$ ruby -wc /tmp/1541.rb 
/tmp/1541.rb:1: warning: encountered \r in middle of line, treated as a mere space
/tmp/1541.rb:1: syntax error, unexpected tIDENTIFIER, expecting end-of-input
Version 1.0.30 - Feb 7 2016
                   ^~~~~~~