Support newer nokogiri as well #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To address security vulnerability only resolved in nokogiri 1.10.4
satoryu
reviewed
Dec 30, 2019
| @@ -12,7 +12,7 @@ Gem::Specification.new do |s| | |||
| s.homepage = 'https://github.com/chrahunt/docx' | |||
| s.files = Dir["README.md", "LICENSE.md", "lib/**/*.rb"] | |||
|
|
|||
| s.add_dependency 'nokogiri', '~> 1.8', '>= 1.8.1' | |||
There was a problem hiding this comment.
As said in the comment #71 (comment) , this add_dependency covers 1.10.4 or later.
If you would like to ensure fixed version of nokogiri must be installed, '~> 1.10', '>= 1.10.4' looks better.
There was a problem hiding this comment.
You're right. Fixed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per issue #71 - address security vulnerability only resolved in nokogiri 1.10.4