New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Git module config method #399

Merged

jcouball merged 2 commits into ruby-git:master from toptal:fix_config_set_when_no_git_dir

Dec 23, 2020

Contributor

mpapis commented Jan 21, 2019 •

edited

Loading

Your checklist for this pull request

🚨Please review the guidelines for contributing to this repository.

Ensure all commits include DCO sign-off.
Ensure that your contributions pass unit testing.
Ensure that your contributions contain documentation if applicable.

Description

The Git module config method when used via include Git does not work
as the lambda requires parameters to be present and the second part of
condition in Git::Lib::config_get calls the lambda without any params,
switching to Proc.new fixes the problem.

mpapis mentioned this pull request

Remove the Git monkeypatches toptal/codeowners-checker#10

Open

stale bot commented Mar 22, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added wontfix and removed wontfix labels


          Fix Git module config method

5b12f82

The Git module config method when used via `include Git` does not work
as the `lambda` requires parameters to be present and the second part of
condition in Git::Lib::config_get calls the lambda without any params,
switching to `Proc.new` fixes the problem.

Signed-off-by: Michal Papis <michal.papis@toptal.com>

mpapis force-pushed the fix_config_set_when_no_git_dir branch from 79eceaa to 5b12f82 Compare

March 25, 2019 12:59

Contributor Author

mpapis commented Mar 25, 2019

tests are passing, the code is rebased, anything else I should do?

stale bot commented May 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the wontfix label

Contributor Author

mpapis commented May 28, 2019

still waiting for the review

stale bot removed the wontfix label

stale bot commented Jul 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the wontfix label

Contributor Author

mpapis commented Jul 30, 2019

still waiting for the review

stale bot removed the wontfix label

stale bot commented Sep 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the wontfix label

Contributor Author

mpapis commented Sep 30, 2019

still waiting for the review

stale bot removed the wontfix label

stale bot commented Nov 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale bot added the wontfix label

Contributor Author

mpapis commented Nov 29, 2019

still waiting for the review

stale bot removed the wontfix label

mpapis mentioned this pull request

Allow creating new config entries #398

Closed

3 tasks

stale bot commented Jan 28, 2020

A friendly reminder that this issue had no activity for 60 days.

stale bot added the stale label


          Merge branch 'master' into fix_config_set_when_no_git_dir

c08c702

stale bot removed the stale label

jcouball approved these changes

View reviewed changes

Member

jcouball left a comment

I have reviewed this change and it looks good. Thank you!

jcouball merged commit 181ace3 into ruby-git:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet