Fix error when calling Git::Lib#remove with recursive or cached options
#632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…array. Signed-off-by: Naotaka Nakane <n.nakane0219@gmail.com> Signed-off-by: naotaka nakane <n.nakane0219@gmail.com>
gtnao
force-pushed
the
fix-remove-with-recursive-or-cached
branch
from
97ad381
to
9be6dc7
Compare
Signed-off-by: James Couball <jcouball@yahoo.com>
|
Hello @gtnao0219! Thank you for reporting and fixing this bug! This points out that we don't have test coverage for In addition, I renamed |
Signed-off-by: James Couball <jcouball@yahoo.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
🚨Please review the guidelines for contributing to this repository.
Description
Calling
Git::Lib#removewithrecursiveorcachedoption causes nested array assignment tocmdargument ofGit::Lib#commandand throws exception.It is caused by passing an array to
Array#<<.fix #631