Add fetch method to fetch from opts_hash #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like it. This needs tests and a CHANGELOG entry please. |
alanjcfs
force-pushed
the
add-fetch-to-entity-options
branch
4 times, most recently
from
0293322
to
f912e28
Compare
Add a line to CHANGELOG about fetch method Add specs for `#fetch` `#fetch` will pass the method to the option hash.
alanjcfs
force-pushed
the
add-fetch-to-entity-options
branch
from
f912e28
to
c42f4b6
Compare
|
@dblock Thanks for the feedback. I added the specs at the end of the spec as there was no specific specs for Grape::Entity::Options. Let me know if there's anything to improve. I also squashed the commits. |
|
Merged, looks good. |
|
It's pretty long time so maybe it would be nice to release new version with this 😇 |
|
@idyll @marshall-lee ^^^ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use
fetchoften to get options (raising an error if an option doesn't exist) as well as to provide a alternative value if an option is not provided.