-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove pre-2.2.2 rubies since they no longer work with AS 5 (#1440) #1441
Conversation
Grape itself is compatible with AS 5. When we add it to .gemspec we're saying that it's not, which isn't true. I would take a PR that fixes the build and removes old(er) rubies instead? |
b970a44
to
2de68a5
Compare
Changed commit to remove pre-2.2.2 versions of ruby (2.2, 2.1, 2.0.0, jruby-19mode) from .travis.yml, and replace them with 2.2.2, 2.2.3, 2.2.4, 2.2.5 and 2.3.1 |
- 2.2 | ||
- 2.1 | ||
- 2.0.0 | ||
- 2.2.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we don't need to build all those, how about just the latest 2.2 (does just 2.2 work)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think '2.2' will pick up 2.2.0, not 2.2.5 (which is the latest 2.2.x release). How about 2.2.5 and 2.3.1? (omitting 2.2.2, 2.2.3, 2.2.4, and 2.3.0)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I would leave 2.3.0 just cause it's recent enough.
Updated PR to build only 2.2.5, 2.3.0, 2.3.1. Moved CHANGELOG entry to features section. Added text in UPGRADING. @dblock |
Merged. |
* Reduce build matrix, run Danger once. * Restore testing for Ruby 2.1 and 2.0, undoes #1441.
No description provided.