Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pre-2.2.2 rubies since they no longer work with AS 5 (#1440) #1441

Merged
merged 1 commit into from
Jul 17, 2016

Conversation

jlfaber
Copy link
Contributor

@jlfaber jlfaber commented Jul 14, 2016

No description provided.

@jlfaber jlfaber changed the title Lock activesupport to >= 4.2.x, < 5.0.0 (#1440) Restrict activesupport version to < 5.0.0 (#1440) Jul 14, 2016
@dblock
Copy link
Member

dblock commented Jul 15, 2016

Grape itself is compatible with AS 5. When we add it to .gemspec we're saying that it's not, which isn't true. I would take a PR that fixes the build and removes old(er) rubies instead?

@jlfaber jlfaber changed the title Restrict activesupport version to < 5.0.0 (#1440) Remove pre-2.2.2 rubies since they no longer work with AS 5 (#1440) Jul 15, 2016
@jlfaber jlfaber force-pushed the issue_#1440 branch 2 times, most recently from b970a44 to 2de68a5 Compare July 15, 2016 22:33
@jlfaber
Copy link
Contributor Author

jlfaber commented Jul 15, 2016

Changed commit to remove pre-2.2.2 versions of ruby (2.2, 2.1, 2.0.0, jruby-19mode) from .travis.yml, and replace them with 2.2.2, 2.2.3, 2.2.4, 2.2.5 and 2.3.1

- 2.2
- 2.1
- 2.0.0
- 2.2.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we don't need to build all those, how about just the latest 2.2 (does just 2.2 work)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think '2.2' will pick up 2.2.0, not 2.2.5 (which is the latest 2.2.x release). How about 2.2.5 and 2.3.1? (omitting 2.2.2, 2.2.3, 2.2.4, and 2.3.0)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I would leave 2.3.0 just cause it's recent enough.

@jlfaber
Copy link
Contributor Author

jlfaber commented Jul 16, 2016

Updated PR to build only 2.2.5, 2.3.0, 2.3.1. Moved CHANGELOG entry to features section. Added text in UPGRADING. @dblock

@dblock dblock merged commit 3802f81 into ruby-grape:master Jul 17, 2016
@dblock
Copy link
Member

dblock commented Jul 17, 2016

Merged.

@jlfaber jlfaber deleted the issue_#1440 branch July 17, 2016 17:03
dblock added a commit to dblock/grape that referenced this pull request Jul 26, 2016
dblock added a commit that referenced this pull request Jul 26, 2016
* Reduce build matrix, run Danger once.

* Restore testing for Ruby 2.1 and 2.0, undoes #1441.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants