Fix Hash params renaming #1903
Merged
Fix Hash params renaming #1903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bikolya
force-pushed
the
fix-nested-params-renaming
branch
from
17ad35c
to
c8da7df
Compare
dblock
requested changes
Aug 30, 2019
bikolya
force-pushed
the
fix-nested-params-renaming
branch
from
c8da7df
to
c57d97c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it wasn't possible to rename attributes that have a block: https://github.com/ruby-grape/grape/blob/master/lib/grape/dsl/parameters.rb#L134. Known side effects: renamed keys aren't removed from
paramsand cause duplication there, butdeclared(params)keeps only the correct keys.This PR doesn't fix the problem with duplication of keys in the
paramshash when a deeply nested attribute or an attribute with a block is renamed. Here we remove renamed keys https://github.com/ruby-grape/grape/blob/master/lib/grape/endpoint.rb#L327-L332, but the only place we mark keys for deletion is here: https://github.com/ruby-grape/grape/blob/master/lib/grape/validations/params_scope.rb#L128 and it doesn't cover the case of hash/array attributes with block or even ordinary nested attributes.