Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bloat in released gem. #1937

Merged
merged 1 commit into from
Dec 1, 2019
Merged

Fix bloat in released gem. #1937

merged 1 commit into from
Dec 1, 2019

Conversation

dblock
Copy link
Member

@dblock dblock commented Nov 29, 2019

Closes #1936.

@grape-bot
Copy link

grape-bot commented Nov 29, 2019 •
edited
Loading

1 Message
📖 We really appreciate pull requests that demonstrate issues, even without a fix. That said, the next step is to try and fix the failing tests!

Generated by 🚫 danger

@dblock dblock mentioned this pull request Nov 29, 2019
Closed
@dblock dblock requested a review from myxoh November 29, 2019 17:40
dm1try
dm1try reviewed Nov 29, 2019
View reviewed changes
grape.gemspec Outdated Show resolved Hide resolved
dm1try
dm1try reviewed Nov 29, 2019
View reviewed changes
grape.gemspec Outdated Show resolved Hide resolved
dm1try
dm1try approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@dm1try dm1try left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, see the comments)

@dblock dblock merged commit d69c104 into ruby-grape:master Dec 1, 2019
@dblock dblock deleted the fix-gemspec branch December 1, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dm1try dm1try dm1try approved these changes

@myxoh myxoh Awaiting requested review from myxoh

Assignees

@dm1try dm1try

@myxoh myxoh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gem bloat
4 participants
@dblock @grape-bot @dm1try @myxoh