Fixes issue by checking if there's a base is there at all #1946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
reviewed
Dec 17, 2019
CHANGELOG.md
Outdated
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| #### Fixes | |||
|
|
|||
| * Your contribution here. | |||
| * [#1931](https://github.com/ruby-grape/grape/pull/1946): Fixes issue when using namespaces in Grape::API::Instance mounted directly - [@myxoh](https://github.com/myxoh) | |||
There was a problem hiding this comment.
Needs a period. Quote Grape::API::Instance.
dblock
reviewed
Dec 17, 2019
| @@ -121,7 +121,7 @@ def evaluate_as_instance_with_configuration(block, lazy: false) | |||
| self.configuration = value_for_configuration | |||
| response | |||
| end | |||
| if base_instance? && lazy | |||
| if base && base_instance? && lazy | |||
There was a problem hiding this comment.
Should we be doing this check inside base_instance?
There was a problem hiding this comment.
I don't think it makes sense, as base_instance? usually means: "This instance is not used anywhere and is just a template for other instances" while, if an API has no base, it will most likely be used directly
|
Thanks for a quick fix! |
basjanssen
pushed a commit
to basjanssen/grape
that referenced
this pull request
Feb 28, 2020
sadgb
pushed a commit
to sadgb/grape
that referenced
this pull request
Mar 10, 2021
…#1946) # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue raised here: #1945
The cause of the issue is the introduction of the
LazyBlockwhere blocks would only be excecuted on properly mounted instances, the side effect is for people using justInstancethey had no base at all.