Be sure classes/modules listed for autoload really exist #1976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnesteryuk
force-pushed
the
bugfix/autoload
branch
from
f2ff737
to
69b65fe
Compare
dblock
requested changes
Jan 15, 2020
CHANGELOG.md
Outdated
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| #### Fixes | |||
|
|
|||
| * [#1976](https://github.com/ruby-grape/grape/pull/1976): Be sure classes/modules listed for autoload really exist - [@dnesteryuk](https://github.com/dnesteryuk). | |||
spec/spec_helper.rb
Outdated
| @@ -10,6 +10,26 @@ | |||
| require 'bundler' | |||
| Bundler.require :default, :test | |||
|
|
|||
| # Grape uses autoload https://api.rubyonrails.org/classes/ActiveSupport/Autoload.html. | |||
There was a problem hiding this comment.
Let's put this in https://github.com/ruby-grape/grape/tree/master/spec/support, call it eager_load.rb and call this function eager_load! to follow the Ruby pattern.
dnesteryuk
force-pushed
the
bugfix/autoload
branch
from
69b65fe
to
752bf4c
Compare
|
@dblock thanks for the review, please, have a look again 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1972