Another array allocation reduction #2020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
Convert literal array in CONST Replace =~ or match by match? when we don't need the MatchData object. match? function is new from 2.4 Add CHANGELOG.md Add SafeOperator before match Add upgrade notice for Array[String] If Array[String] is used without a coerce_with block, existing APIs may quietly fail without explanation. This change to the upgrade documentation makes that clear. Closes ruby-grape#2013 Add upgrade notice on upgrading all Array types Previously Vitrus implicitly coerced strings to integers when Array[Integer] types were used. With dry-types, this is no longer done, and APIs that expected this behavior will fail with an invalid type check. Expand the upgrade docs to include all Array types and an example for Array[Integer]. Add CHANGELOG.md
ericproulx
force-pushed
the
another_array_allocation_reduction
branch
from
7d764ff
to
da75f7b
Compare
dblock
reviewed
Mar 17, 2020
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| #### Features | |||
| * Your contribution here. | |||
| * [#2020](https://github.com/ruby-grape/grape/pull/2020): Reduce array allocation - [@ericproulx](https://github.com/ericproulx). | |||
There was a problem hiding this comment.
For next time, you can do [#2020](https://github.com/ruby-grape/grape/pull/2020), [#2014](https://github.com/ruby-grape/grape/pull/2014): Reduce ....
|
Minor. For next time, try amending your commit (git add ; git commit --amend) and force pushing the branch, so we end up with a neat single commit in these PRs :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found another place where we can reduce array allocation.