Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Decimal type category #2025

Merged
merged 3 commits into from
Mar 20, 2020
Merged

Fix Decimal type category #2025

merged 3 commits into from
Mar 20, 2020

Conversation

kdoya
Copy link
Contributor

@kdoya kdoya commented Mar 19, 2020

It may be more useful by using DryTypes::Params::Decimal. Because DryTypes::Coercible::Decimal fails coercing 45.1 for json reqeust.

Fix Decimal type category
76201b8 
It may be more useful by Dry::Types['params.decimal']
dnesteryuk
dnesteryuk approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@dnesteryuk dnesteryuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable 👍

@dblock
Copy link
Member

dblock commented Mar 19, 2020

Not sure what happened to the bot, but this fixes a bug and needs a changelog entry, please.

@dblock dblock merged commit c8fd21b into ruby-grape:master Mar 20, 2020
@kdoya
Copy link
Contributor Author

kdoya commented Mar 20, 2020

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dnesteryuk dnesteryuk dnesteryuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kdoya @dblock @dnesteryuk