coercing of nested arrays #2054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is a regression which was introduced after migrating to DryTypes.
Now, it is again possible to define an array of arrays as a type.
params do
requires :skills, type: Array[[String]]
end
dblock
reviewed
May 15, 2020
| @@ -18,26 +18,27 @@ def initialize(type, strict = false) | |||
| super | |||
|
|
|||
| @coercer = scope::Array | |||
| @elem_coercer = PrimitiveCoercer.new(type.first, strict) | |||
| @nested = type.first.is_a?(Array) | |||
There was a problem hiding this comment.
Array or any kind of enumerable? Sets of sets?
dblock
approved these changes
May 16, 2020
| class << self | ||
| def inherited(klass) | ||
| # share the hash with classes, so inheritors could will it | ||
| klass.instance_variable_set(:@collection_coercers, collection_coercers) |
There was a problem hiding this comment.
Feels dirty. Maybe we can add a coercers= method?
| expect(subject.call([%w[10 20]])).to eq([Set[10, 20]]) | ||
| expect(subject.call([['10'], ['20']])).to eq([Set[10], Set[20]]) | ||
| end | ||
| end |
There was a problem hiding this comment.
Let's add a test with one more level of nesting?
Can I do a set of arrays?
|
@dblock thanks for the quick review 👍 I've improved the design 😊 We can avoid sharing any structure with inheritors. |
Better. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a regression which was introduced after migrating to DryTypes. Now, it is again possible to define an array of arrays as a type.
Fixes #2041