Remove non-UTF-8 characters from format before generating JSON error #2234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dm1try
approved these changes
Jan 11, 2022
|
Thanks for the quick merge, and all of your work on Grape! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we receive a request with an unsupported format, that user-provided format is included in the generated error message. If the format includes non-UTF-8 characters and the app is configured to generate JSON error messages, a
JSON::GeneratorErroris raised.To work around this error, this PR uses
String#encode's ability to replace invalid and undefined UTF-8 characters before callingGrape::Json::dump.