added cookie deletion params #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w/o such modification API servers ain't able to remove cookies set for different paths
|
This needs a test, please and an entry in CHANGELOG. |
|
Sorry I'm not familiar w/ testing on Ruby yet. |
|
No problem, looking forward to your contribution. |
dblock
added a commit
that referenced
this pull request
Dec 29, 2012
|
Fyi, I merged the change, fixed it for Ruby 1.8.7, updated README, wrote a spec and added to CHANGELOG, see a65068b. |
|
Changes Unknown when pulling 8e8d74e on nilfalse:master into * on intridea:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
w/o such modification API servers ain't able to remove cookies set for different paths
e.g.:
cookies[:token] = { value: 'here is a token cookie', path: '/', httponly: true }won't be deleted by simply
cookies.delete :tokeninstead you have to pass additional path option to remove proper cookie
cookies.delete :token, path: '/'tested on Firefox 18 Mac, Ruby 1.9.3