Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature test for issue #606 and disable the optimization if the bug is present #618

Closed

Conversation

casperisfine
Copy link

Fix: #606

Apologies for the delay, I was somehow convinced I already submitted this...

Note that the fix for the root cause was merged msgpack/msgpack-ruby#246, and it seems like there wasn't that many people impacted, so I'm personally not convinced the workaround is worth it, but of course it's your call.

If you want to ship a workaround, that's how I'd do it.

@radar

cc @paarthmadan

@paarthmadan
Copy link
Contributor

My two-cents:

I agree that the feature testing isn't worth it. It would appear the number of clients affected isn't worth bloating the logic required for performing the feature test.

@radar
Copy link
Collaborator

radar commented Feb 14, 2022

@paarthmadan I agree here. It's likely a (future) bundle update msgpack will make the issue go away. Once the next msgpack version comes out, I feel like this issue will be permanently resolved.

Thank you, and @casperisfine for your working through this issue. I appreciate the assist!

@radar radar closed this Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants