-
Notifications
You must be signed in to change notification settings - Fork 253
Make all specs green #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1. String#encode should not fail if given an invalid code like '\x81' This is because this problem has been resolved by ruby-ldap#41. 2. Net::LDAP#search should return a boolean if return_result is false.
Fix typo
Sweet! :) Thanks for taking care of this |
my pleasure 🍺 |
rvm: | ||
- 1.8.7 | ||
- 1.9.2 | ||
- 1.9.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about:
- 2.0.0
- 1.9.3
- 1.9.2
- jruby-18mode
- jruby-19mode
- rbx-18mode
- rbx-19mode
- 1.8.7
- ree
It'd be nice to have stronger assurances, and it's 'free' anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am out of the office until 17.04.2013.Meine E-Mails werden nicht gelesen oder weitergeleitet.Gerne werde ich nach meiner Rückkehr Ihre Nachricht beantworten.In dringenden Fällen erreichen Sie uns unter info@iq-gmbh.com oder Tel. 0049 5031 9408-0.Vielen herzlichen Dank.Note: This is an automated response to your message "Re: [ruby-net-ldap] Make all specs green (#59)" sent on 12.04.2013 08:11:53. This is the only notification you will receive while this person is away.
i.Q. Gesellschaft für individuelle Qualitätssicherung mbH
Kirschenkamp 3
D-30926 Seelze
Geschäftsführer: Thomas Schreier
Amtsgericht Hannover HRB 110570
Umsatzsteuer-ID: DE173555521
Make all specs green
Since some pull requests were accepted, 2 examples doesn't work.
The commits in this pull request fixes it and add travis.yml to adopt travix-ci.
Thanks,