Skip to content

Conversation

satoryu
Copy link
Collaborator

@satoryu satoryu commented Mar 13, 2013

Since some pull requests were accepted, 2 examples doesn't work.
The commits in this pull request fixes it and add travis.yml to adopt travix-ci.

Thanks,

Tatsuya Sato and others added 4 commits March 13, 2013 16:25
1. String#encode should not fail if given an invalid code like '\x81'
This is because this problem has been resolved by ruby-ldap#41.

2. Net::LDAP#search should return a boolean if return_result is false.
@johnyb
Copy link

johnyb commented Apr 7, 2013

Sweet! :) Thanks for taking care of this

@satoryu
Copy link
Collaborator Author

satoryu commented Apr 7, 2013

my pleasure 🍺

rvm:
- 1.8.7
- 1.9.2
- 1.9.3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about:

- 2.0.0
- 1.9.3
- 1.9.2
- jruby-18mode
- jruby-19mode
- rbx-18mode
- rbx-19mode
- 1.8.7
- ree

It'd be nice to have stronger assurances, and it's 'free' anyway.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am out of the office until 17.04.2013.Meine E-Mails werden nicht gelesen oder weitergeleitet.Gerne werde ich nach meiner Rückkehr Ihre Nachricht beantworten.In dringenden Fällen erreichen Sie uns unter info@iq-gmbh.com oder Tel. 0049 5031 9408-0.Vielen herzlichen Dank.Note: This is an automated response to your message "Re: [ruby-net-ldap] Make all specs green (#59)" sent on 12.04.2013 08:11:53. This is the only notification you will receive while this person is away.
i.Q. Gesellschaft für individuelle Qualitätssicherung mbH
Kirschenkamp 3
D-30926 Seelze
Geschäftsführer: Thomas Schreier
Amtsgericht Hannover HRB 110570
Umsatzsteuer-ID: DE173555521

RoryO pushed a commit that referenced this pull request Jul 22, 2013
@RoryO RoryO merged commit a808c89 into ruby-ldap:master Jul 22, 2013
@satoryu satoryu deleted the make_spec_green branch July 23, 2013 14:24
astratto pushed a commit to astratto/ruby-net-ldap that referenced this pull request Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants