Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rake-compiler to make development a bit easier #164

Merged
merged 1 commit into from
May 7, 2020

Conversation

ankane
Copy link
Contributor

@ankane ankane commented May 6, 2020

Just a suggestion, so feel free to close without comment if there's not any interest. This should make development a bit more standard as well as easier for Mac users (I believe it can eliminate the need for the custom setup scripts).

Edit - Here's the link: https://github.com/rake-compiler/rake-compiler

bundle exec rake compile

On Mac, the current setup.rb script doesn't return any errors, but doesn't appear to compile the extension.

ruby setup.rb compile
(ruby 2.7.1 x86_64-darwin18)

- - COMPILE - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 

Instead, my workflow as been:

ruby ext/numo/narray/extconf.rb
make
cp narray.bundle lib/numo/narray.bundle

@masa16 masa16 merged commit 078aa3b into ruby-numo:master May 7, 2020
@ankane
Copy link
Contributor Author

ankane commented May 7, 2020

Thanks @masa16!

@kojix2 kojix2 mentioned this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants