Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Matterport provider #93

Merged
merged 3 commits into from
Feb 25, 2024

Conversation

papes1ns
Copy link
Contributor

Supports rich interactive Matterport embeds without the need for relying on the fallback aggregators.

Matterport lets you create and embed 3D models of buildings and spaces, e.g. https://my.matterport.com/show/?m=FmDYedjofjo. Credit to @haeric for finding the Matterport oEmbed provider URL.

Copy link
Collaborator

@metavida metavida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing a new provider! I'm not exactly sure when I'll have time to release a new version of the gem, but I've got it on my TODO list for when I do manage to find the free time.

@papes1ns
Copy link
Contributor Author

papes1ns commented Feb 2, 2024

Appreciate the feedback!

Really enjoy using this gem. Decided to contribute by officially adding Matterport as a provider, aiming to simplify integration for future devs and spare them the hassle of hunting down the right docs. They were not trivial to find :)

@metavida metavida merged commit 54a8497 into ruby-oembed:master Feb 25, 2024
3 checks passed
metavida added a commit that referenced this pull request Feb 25, 2024
@metavida
Copy link
Collaborator

metavida commented Mar 3, 2024

FYI, I released the Materport provider with 0.17.0 back on February 25. Thanks again for the contribution & so glad you like the gem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants