Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could a soft dependency on multi_json abstraction be used #18

Closed
abargnesi opened this issue Aug 19, 2015 · 1 comment
Closed

Could a soft dependency on multi_json abstraction be used #18

abargnesi opened this issue Aug 19, 2015 · 1 comment
Assignees

Comments

@abargnesi
Copy link

I see the ruby JSON implementation is used to read the input.

Would it be desired to provide a soft dependency (i.e. not declared in gemspec) on the multi_json gem? This would allow users to supply a more efficient JSON parser for their ruby engine. On MRI that is likely Oj, on JRuby that is likely jrjackson.

The required work is pretty minimal:

  • Test for multi_json dependency on LOAD_PATH.
  • If present, parse JSON-LD with MultiJson.load.
  • If not, fall back to JSON module.
@gkellogg
Copy link
Member

Good idea; this has been suggested before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants