Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the RDF.rb version dependency #22

Closed
artob opened this issue Nov 9, 2015 · 5 comments
Closed

Correct the RDF.rb version dependency #22

artob opened this issue Nov 9, 2015 · 5 comments
Assignees
Labels

Comments

@artob
Copy link
Member

artob commented Nov 9, 2015

It'd probably be a good idea to tighten the RDF.rb version dependency a bit on the JSON::LD 1.1.x branch, as right now it will happily pull in RDF.rb 1.99.x on a machine that doesn't already have it installed:

$ sudo gem install json-ld -v 1.1.11
Fetching: link_header-0.0.8.gem (100%)
Fetching: rdf-1.99.0.gem (100%)
Fetching: multi_json-1.11.2.gem (100%)
Fetching: json-ld-1.1.11.gem (100%)
Successfully installed link_header-0.0.8
Successfully installed rdf-1.99.0
Successfully installed multi_json-1.11.2
Successfully installed json-ld-1.1.11
4 gems installed

This means that in normal use, users will see tons of deprecation notices for what ought to be a production release of the JSON::LD library and CLI utility.

@artob artob added the bug label Nov 9, 2015
@gkellogg
Copy link
Member

gkellogg commented Nov 9, 2015

I suppose the right thing is to release this as json-ld 1.99.0, and yank 1.1.11. I'll check other gems as well.

@artob
Copy link
Member Author

artob commented Nov 9, 2015

Alternatively, couldn't the gemspec for the 1.1.x branch just specify "< 1.99" in the dependency? That is, it'd be good to keep a production version around, as 1.99 can't be considered that given the voluminous deprecation warnings.

@gkellogg
Copy link
Member

gkellogg commented Nov 9, 2015

No, it was updated to use graph_name, which is in 1.99.

@gkellogg
Copy link
Member

gkellogg commented Nov 9, 2015

Released 1.1.11.1 with RDF versions < 1.99

@gkellogg gkellogg closed this as completed Nov 9, 2015
@artob
Copy link
Member Author

artob commented Nov 9, 2015

Thanks @gkellogg, the 1.1.11.1 version works great (doesn't output warnings).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants