Clean up Rack input stream handling #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parser methods used to try to handle Strings, as well as valid Rack inputs. This led to some unnecessary complexity, giving rise to errors like those seen in #56. This refactors to handle only IO-like Rack Input streams. Most of the work here is just to reorganize the tests. There is an odd case where `RDFSource#update` feeds the IO stream before trying to parse a graph. For now, we aggressively `#rewind` the stream in `#parse_graph` to this problem. This might be unduely costly, and there is probably a better fix in the long run.
added 3 commits
June 26, 2016 14:12
We called a couple of methods which were out of scope for Rack input streams: `#eof?` and `#binmode`. This fixes things up so we can pass a Rack::Lint.
We use status code 204 on HTTP DELETE responses. `Rack::Lint` correctly objects to returning a `Content-Type` header for these responses. We strip it and return an empty body (rather than an empty String) for DELETE requests.
The base Lamprey server now includes Rack::Lint. This has some runtime overhead, but users concerned about this should be able to spin up their own servers without the lint layer pretty easily. This has the benefit of forcing linting when running the W3C test suite. Closes #58.
|
Closes #58 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser methods used to try to handle Strings, as well as valid Rack
inputs. This led to some unnecessary complexity, giving rise to errors
like those seen in #56. This refactors to handle only IO-like Rack Input
streams.
Most of the work here is just to reorganize the tests.
There is an odd case where
RDFSource#updatefeeds the IO stream beforetrying to parse a graph. For now, we aggressively
#rewindthe streamin
#parse_graphto this problem. This might be unduely costly, andthere is probably a better fix in the long run.
The later commits introduce
Rack::Lintand deal with a few issues found by running the existing tests and the W3C suite with those in place.