Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versions 0.1.x are incorrectly listed as compatible with Ruby 2.3 #22

Closed
miloprice opened this issue May 7, 2024 · 1 comment
Closed

Comments

@miloprice
Copy link

All versions of base64 use String#unpack1, introduced in Ruby 2.4.

In #17, the gemspec was updated to declare Ruby >= 2.4 as a dependency, but this change was only published in base64 v0.2.0. As a result, v0.1.0 and v0.1.1 are still published as being compatible with Ruby 2.3, despite causing base64 decoding to fail when run in a Ruby 2.3 app.

To remedy this, would it be possible to do either of the following:

  1. Yank v0.1.0 and v0.1.1, since they have incorrect dependencies declared, and publish new versions v0.1.0.1 and v0.1.1.1 with correctly declared Ruby >= 2.4
  2. Publish a Ruby 2.3-compatible version v0.1.2 that doesn't rely on String#unpack1

If the second option would be preferable, I can put up a PR.

kolatat added a commit to kolatat/base64 that referenced this issue Sep 17, 2024
- Ruby 2.3-compatible: doesn't rely on String#unpack1
- fix ruby#22
@hsbt
Copy link
Member

hsbt commented Oct 16, 2024

Done https://github.com/ruby/base64/releases/tag/v0.1.2

@hsbt hsbt closed this as completed Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants