Enhanced RDoc for BigDecimal #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mrkn, this is big, I know. (I got carried away!) We can work on this piecemeal if you like. |
|
@BurdetteLamar Now I'm working on some bug fixes and improvements of bigdecimal for the Ruby 3.1 release. |
mrkn
reviewed
Dec 21, 2021
Remove the instance number of `Float::DIG`.
mrkn
reviewed
Dec 21, 2021
Add BigDecimal call-seq without ndigits.
mrkn
reviewed
Dec 21, 2021
Replace the word sum with value or result in the description of BigDecimal().
mrkn
reviewed
Dec 21, 2021
Remove the instance value of Float::DIG.
mrkn
reviewed
Dec 21, 2021
Fix mis-description of precision
mrkn
reviewed
Dec 21, 2021
Fix the description of precision determination
mrkn
reviewed
Dec 21, 2021
Add the description of the precision in the Rational case.
mrkn
added a commit
to mrkn/ruby
that referenced
this pull request
Dec 23, 2021
* Enhanced RDoc for BigDecimal * Update ext/bigdecimal/bigdecimal.c Remove the instance number of `Float::DIG`. * Update ext/bigdecimal/bigdecimal.c Add BigDecimal call-seq without ndigits. * Update ext/bigdecimal/bigdecimal.c Replace the word sum with value or result in the description of BigDecimal(). * Update ext/bigdecimal/bigdecimal.c Remove the instance value of Float::DIG. * Update ext/bigdecimal/bigdecimal.c Fix mis-description of precision * Update ext/bigdecimal/bigdecimal.c Fix the description of precision determination * Update ext/bigdecimal/bigdecimal.c Add the description of the precision in the Rational case. ruby/bigdecimal@acabb132a4 Co-authored-by: Kenta Murata <3959+mrkn@users.noreply.github.com>
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Dec 23, 2021
* Enhanced RDoc for BigDecimal * Update ext/bigdecimal/bigdecimal.c Remove the instance number of `Float::DIG`. * Update ext/bigdecimal/bigdecimal.c Add BigDecimal call-seq without ndigits. * Update ext/bigdecimal/bigdecimal.c Replace the word sum with value or result in the description of BigDecimal(). * Update ext/bigdecimal/bigdecimal.c Remove the instance value of Float::DIG. * Update ext/bigdecimal/bigdecimal.c Fix mis-description of precision * Update ext/bigdecimal/bigdecimal.c Fix the description of precision determination * Update ext/bigdecimal/bigdecimal.c Add the description of the precision in the Rational case. ruby/bigdecimal@acabb132a4 Co-authored-by: Kenta Murata <3959+mrkn@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Treated:
Plus some minor tweaks to previous updates.