Allow :newline option to CSV.open #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `:newline` has priority over `:universal_newline` etc. in `IO.open`, so deal with both. On the other hand, such options cannot be passed to `CSV#initialize`.
nobu
force-pushed
the
newline-options
branch
from
8c8f173
to
ef55948
Compare
esparta
reviewed
Dec 29, 2020
Co-authored-by: Espartaco Palma <esparta@gmail.com>
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As
:newlinehas priority over:universal_newlineetc. inIO.open, so deal with both.On the other hand, such options cannot be passed to
CSV#initialize.