Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add news for v1.0.2 #36

Merged
merged 1 commit into from
May 3, 2018
Merged

Add news for v1.0.2 #36

merged 1 commit into from
May 3, 2018

Conversation

tricknotes
Copy link
Contributor

@tricknotes tricknotes commented May 2, 2018

I updated news.md for preparing a new release.
From: #23 (comment)

@kou
I read v1.0.1...d8d183d1 and listed the changes affected to csv gem users.
Is it enough as news?
If there are any missing infomation, please comment me what should be listed :-)


Rendered

@kou
Copy link
Member

kou commented May 2, 2018

Thanks!
It doesn't need to list "Patch by Kouhei Sutou" because I'm a maintainer. :-)
It should list reporter instead of it. For example, we should use "Reported by Pavel Lobashov" for #23. Contributor (including you) information is very important.

Document notable changes for v1.0.1...d8d183d.
Link: ruby/csv@v1.0.1...d8d183d

"notable" is the change for the csv gem users face.
@tricknotes
Copy link
Contributor Author

tricknotes commented May 3, 2018

Thanks for your feedback!
I understood that the information about contributors is important :-)

So I updated news.md with this diff .
Could you review this PR again?

@kou kou merged commit e675798 into ruby:master May 3, 2018
@kou
Copy link
Member

kou commented May 3, 2018

Great!
I've released 1.0.2.

@tricknotes tricknotes deleted the news-for-1.0.2 branch May 3, 2018 12:03
@tricknotes
Copy link
Contributor Author

Woot!!
Awesome thanks ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants