Improve code samples #15
Conversation
Fix some bugs and make minor improvements.
Use iterators or "loop" instead of "for" and "while" loops, consistently use double quotes, drop unnecessary "then" etc.
Introduce some variables and methods, simplify file slurping and random position generation, drop some comments etc.
| * win.addstr(my_str) | ||
| * # or even | ||
| * win << "\nORLY" | ||
| * win << "\nOH REALLY?" |
There was a problem hiding this comment.
not that easy to understand for non-native speakers... had to look it up...
|
I like these improvements. You could also swap the |
|
I only split the assignments in the basic example, not in the more elaborate ones. ok? I essentially never use ARGF, so I'm not sure about it; but do feel free to change as you like :) |
|
(Travis CI seems to be broken since a couple of builds...) |
|
Travis seems to be missing a library now, I'll check it later and merge I'll look at switching to ARGF then. Thanks for your work! |
|
@drbrain This PR is almost a year old, and you essentially already approved. Could you please merge? PS. The last commit certainly is not to blame for the failing CI. |
|
@stomar I've merged your pull request. Thanks for your contribution! |
|
@shugo Thanks! And nice to see this is still maintained and improved. |
Major revision of code samples:
All samples tested with Ruby 2.2.