-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Date._iso8601
regression following the 3.2.1 security fix
#39
Comments
Fix: ruby#39 This is how versions previous to 3.2.1 behaved and Active Support currently rely on this behavior. https://github.com/rails/rails/blob/90357af08048ef5076730505f6e7b14a81f33d0c/activesupport/lib/active_support/values/time_zone.rb#L383-L384 Any Rails application upgrading to date `3.2.1` might run into unexpected errors.
And I also faced the regression of CVE-2021-41817 with ruby/spec. |
Oh, good one, I didn't check symbols in my fix. |
Yep:
@hsbt maybe it's best to report this as a separate issue? |
@casperisfine Thanks for your confirmation. It's good to separate from this issue or #40 . |
I pushed the fix for symbols in #40 |
Looks like this also affects Looking forward to a new release with #40 merged |
Fix: ruby/date#39 This is how versions previous to 3.2.1 behaved and Active Support currently rely on this behavior. https://github.com/rails/rails/blob/90357af08048ef5076730505f6e7b14a81f33d0c/activesupport/lib/active_support/values/time_zone.rb#L383-L384 Any Rails application upgrading to date `3.2.1` might run into unexpected errors. ruby/date@8f2d7a0c7e
Fix: #39 This is how versions previous to 3.2.1 behaved and Active Support currently rely on this behavior. https://github.com/rails/rails/blob/90357af08048ef5076730505f6e7b14a81f33d0c/activesupport/lib/active_support/values/time_zone.rb#L383-L384 Any Rails application upgrading to date `3.2.1` might run into unexpected errors.
Previous versions
3.2.1
The text was updated successfully, but these errors were encountered: