Omit #class for simple values
#1004
Open
+538
−473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amomchilov
force-pushed
the
omit-class-for-simple-values
branch
from
11c2a89
to
5ad4edc
Compare
This was referenced Jul 28, 2023
ono-max
approved these changes
Dec 10, 2023
These values are assumed to be 0 if they're missing.
amomchilov
force-pushed
the
omit-class-for-simple-values
branch
from
5ad4edc
to
697cce3
Compare
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ruby/vscode-rdbg#37
This PR depends on the changes in #1001. Only this last commit of this PR is unique to this change.
Description
The class of many values is self-evident and just clutters the UI:
(
falseandnildon't have it, because of this bug described here)This PR omits the usual
#classmember for instances of these classes:NilClassFalseClassTrueClassSymbolStringIntegerFloatClassModuleArrayHashThe result is a much tidier UI you see in the "After" screenshot above.
This change still keeps the
#classfor other types, including subclasses of these simple types. For example,HashWithIndifferentAccessis a subclass ofHash. For clarity, we preserve its#class, but omit it for regular hashes.