Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add trace tests #101

Merged
merged 3 commits into from Jun 17, 2021
Merged

Add trace tests #101

merged 3 commits into from Jun 17, 2021

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jun 17, 2021 •
edited

This PR also adds a new assert_no_line_text test assertion helper.

ko1
ko1 reviewed Jun 17, 2021
View reviewed changes
lib/debug/session.rb Outdated Show resolved Hide resolved
@st0012 st0012 mentioned this pull request Jun 17, 2021
Closed
13 tasks
ko1 added a commit that referenced this pull request Jun 17, 2021
@ko1
trace :raise event cause unlimited loop
9d8f493 
reported at #101
@st0012
Copy link
Member Author

st0012 commented Jun 17, 2021 •
edited

@ko1 I happen to found another bug caused by e436555 and fixed it in 9b68b0e

@st0012
Copy link
Member Author

st0012 commented Jun 17, 2021

@ko1 ah sorry I think it's because I forgot to compile the extension 🤦

@st0012 st0012 requested a review from ko1 June 17, 2021 10:39
ono-max
ono-max requested changes Jun 17, 2021
View reviewed changes
test/support/assertions.rb Outdated Show resolved Hide resolved
ono-max
ono-max approved these changes Jun 17, 2021
View reviewed changes
Copy link
Collaborator

@ono-max ono-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@ko1 ko1 merged commit c22277b into ruby:master Jun 17, 2021
@st0012 st0012 deleted the add-trace-tests branch June 17, 2021 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ono-max ono-max ono-max approved these changes

@ko1 ko1 Awaiting requested review from ko1

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@st0012 @ko1 @ono-max