Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Chrome automatically #334

Merged
merged 4 commits into from
Dec 14, 2021
Merged

Conversation

ono-max
Copy link
Member

@ono-max ono-max commented Oct 19, 2021

To use Chrome debugging, we need the following steps.

  1. Execute Remote debugger such as rdbg --open=chrome target.rb
  2. Open Chrome browser
  3. Copy and paste the URL which is outputted from the terminal in Google Chrome
  4. Open the Source pane.

The steps are long, so I implemented the setup method for Chrome to open the Chrome browser automatically. We can use Chrome debugging as follows:

  1. Execute Remote debugger such as `rdbg --open=chrome target.rb
  2. Open the Source pane.

The following video shows an example of this PR.

Screen.Recording.2021-10-23.at.20.26.24.mov

Note that I'll refactor the process for WebSocket.

@ono-max ono-max force-pushed the open-chrome-automatically branch 5 times, most recently from 7178fcf to a9960cb Compare October 19, 2021 08:12
lib/debug/server.rb Outdated Show resolved Hide resolved
lib/debug/server.rb Outdated Show resolved Hide resolved
lib/debug/server.rb Show resolved Hide resolved
@ono-max ono-max force-pushed the open-chrome-automatically branch 8 times, most recently from c5f5322 to 7bf2944 Compare October 24, 2021 09:22
@ono-max ono-max marked this pull request as ready for review October 24, 2021 09:24
@ono-max ono-max changed the title [WIP] Open Chrome automatically Open Chrome automatically Oct 24, 2021
@ono-max ono-max requested a review from ko1 October 24, 2021 09:24
@ono-max ono-max force-pushed the open-chrome-automatically branch 2 times, most recently from cb6f524 to 98c6d6b Compare October 24, 2021 10:26
lib/debug/server_cdp.rb Outdated Show resolved Hide resolved
lib/debug/server.rb Outdated Show resolved Hide resolved
lib/debug/server.rb Outdated Show resolved Hide resolved
lib/debug/server_cdp.rb Outdated Show resolved Hide resolved
@ono-max ono-max force-pushed the open-chrome-automatically branch 3 times, most recently from 9bfc28f to 1390694 Compare October 26, 2021 12:28
@ono-max ono-max requested a review from ko1 October 26, 2021 12:59
@ono-max ono-max force-pushed the open-chrome-automatically branch 2 times, most recently from afde07d to 2360481 Compare October 27, 2021 10:48
lib/debug/config.rb Outdated Show resolved Hide resolved
@ono-max ono-max requested a review from ko1 October 28, 2021 23:11
@ono-max ono-max force-pushed the open-chrome-automatically branch 2 times, most recently from 5557fdc to e87b5b7 Compare December 7, 2021 00:46
@ono-max ono-max marked this pull request as draft December 7, 2021 12:28
@ono-max ono-max force-pushed the open-chrome-automatically branch 2 times, most recently from 237e9a3 to a1d916c Compare December 8, 2021 08:36
@ono-max ono-max marked this pull request as ready for review December 8, 2021 08:43
@ko1 ko1 merged commit 39bb81d into ruby:master Dec 14, 2021
@ono-max ono-max deleted the open-chrome-automatically branch November 6, 2022 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants