Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform disconnection cleanup and return response before killing debuggee #721

Merged
merged 1 commit into from
Aug 10, 2022
Merged

Perform disconnection cleanup and return response before killing debuggee #721

merged 1 commit into from
Aug 10, 2022

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jul 16, 2022

We do the same for terminate request too. This makes sure the response and bp cleanup are always performed and avoids flaky testing result.

@st0012 st0012 mentioned this pull request Jul 16, 2022
Merged
@ko1 ko1 merged commit 0f2e14f into ruby:master Aug 10, 2022
@st0012 st0012 deleted the make-disconnect-deterministic branch August 10, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st0012 @ko1