Fix #295: Ignore Java package reference objects in JRuby

byteit101 · hsbt · commit 84d030182d3b · 2022-11-17T12:39:00.000+09:00
diff --git a/lib/irb/completion.rb b/lib/irb/completion.rb
@@ -361,6 +361,7 @@ def self.retrieve_completion_data(input, bind: IRB.conf[:MAIN_CONTEXT].workspace
           to_ignore = ignored_modules
           ObjectSpace.each_object(Module){|m|
             next if (to_ignore.include?(m) rescue true)
+            next unless m.respond_to?(:instance_methods) # JRuby has modules that represent java packages. They don't include many common ruby methods
             candidates.concat m.instance_methods(false).collect{|x| x.to_s}
           }
           candidates.sort!

Original file line number	Diff line number	Diff line change
`@@ -361,6 +361,7 @@ def self.retrieve_completion_data(input, bind: IRB.conf[:MAIN_CONTEXT].workspace`
`361`	`361`	`to_ignore = ignored_modules`
`362`	`362`	`ObjectSpace.each_object(Module){\|m\|`
`363`	`363`	`next if (to_ignore.include?(m) rescue true)`
	`364`	`+ next unless m.respond_to?(:instance_methods) # JRuby has modules that represent java packages. They don't include many common ruby methods`
`364`	`365`	`candidates.concat m.instance_methods(false).collect{\|x\| x.to_s}`
`365`	`366`	`}`
`366`	`367`	`candidates.sort!`