Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PoC] Support dialog theme/color configuration #380

Closed
wants to merge 2 commits into from
Closed

[PoC] Support dialog theme/color configuration #380

wants to merge 2 commits into from

Conversation

st0012
Copy link
Member

@st0012 st0012 commented Jul 23, 2022 •
edited
Loading

See https://bugs.ruby-lang.org/issues/19010

Todos

If we want to proceed on this idea, we have the following todos:

  • Add test cases
  • Release reline 0.4.0 for the new APIs
  • Bump reline requirement and drop Ruby 2.5 support because reline now requires 2.6+
    • This includes CI changes
  • Add documentation
  • Automatic background detection to toggle bright theme

@st0012
Copy link
Member Author

st0012 commented Jul 23, 2022

cc @peterzhu2118 @nobu @hsbt

peterzhu2118
peterzhu2118 reviewed Jul 23, 2022
View reviewed changes
Copy link
Member

@peterzhu2118 peterzhu2118 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I like having themes. Makes the UX better.

lib/irb/context.rb Show resolved Hide resolved
This was referenced Jul 24, 2022
Merged
Merged
@st0012 st0012 force-pushed the support-dialog-color-configuration branch from a96074f to 3a44f1c Compare September 18, 2022 21:55
@st0012 st0012 force-pushed the support-dialog-color-configuration branch from 3a44f1c to 81a3583 Compare September 18, 2022 22:07
@st0012 st0012 closed this Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterzhu2118 peterzhu2118 peterzhu2118 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st0012 @peterzhu2118