-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
strict option is broken for pure-Ruby implementation #584
Comments
hsbt
pushed a commit
to hsbt/ruby
that referenced
this issue
Oct 8, 2024
Followup: ruby/json#519 Fix: ruby/json#584
hsbt
pushed a commit
to ruby/ruby
that referenced
this issue
Oct 8, 2024
Followup: ruby/json#519 Fix: ruby/json#584
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In this repo:
But of course Integer should be allowed.
The bug seems clear when looking at
https://github.com/flori/json/blob/4f876a8bf7c45972800bae5bdbaf892aa2f714a5/lib/json/pure/generator.rb#L357-L363
https://github.com/flori/json/blob/4f876a8bf7c45972800bae5bdbaf892aa2f714a5/lib/json/pure/generator.rb#L400-L406
It was added in #519 but with too few tests so they didn't catch this bug.
@byroot / @casperisfine Could you fix this?
The text was updated successfully, but these errors were encountered: