Skip to content

Commit da7bf84

Browse files
committed
Let Logger#reopen not raise on nil log devices
1 parent b42a1b9 commit da7bf84

File tree

2 files changed

+8
-1
lines changed

2 files changed

+8
-1
lines changed

lib/logger.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -410,7 +410,7 @@ def initialize(logdev, shift_age = 0, shift_size = 1048576, level: DEBUG,
410410
# Reopen a log device.
411411
#
412412
def reopen(logdev = nil)
413-
@logdev.reopen(logdev)
413+
@logdev&.reopen(logdev)
414414
self
415415
end
416416

test/logger/test_logger.rb

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -216,6 +216,13 @@ def test_reopen
216216
assert_equal(STDOUT, logger.instance_variable_get(:@logdev).dev)
217217
end
218218

219+
def test_reopen_nil_logdevice
220+
logger = Logger.new(File::NULL)
221+
assert_nothing_raised do
222+
logger.reopen(STDOUT)
223+
end
224+
end
225+
219226
def test_add
220227
logger = Logger.new(nil)
221228
logger.progname = "my_progname"

0 commit comments

Comments
 (0)